[16.0][ADD] web_widget_many2many_binary_preview #3041
Conversation
hbrunn
force-pushed
the
16.0-web_widget_many2many_binary_preview
branch
from
51849d2 to
dd65f80
Compare
| @@ -0,0 +1 @@ | |||
| To use this module, you need to set the attribute `show_preview` to ``True`` on a field with widget `many2many_binary`. | |||
There was a problem hiding this comment.
I like preview better than show_preview, but ah well.
| t-att-src="getUrl(file.id)" | ||
| aria-label="Download" | ||
| download="" | ||
| /> |
There was a problem hiding this comment.
As you already mentioned, the image previews can be rather sizy as compared to the more thumbnaily ones shown in the chatter attachment widget. I've noticed that this this is because of the URL; while here, getUrl returns web/image/XXX?download=true, in the other widget, it returns /web/image/XXX/1920x160 which returns the thumbnail. Maybe you can inject another getUrl and do the same here as well. I don't think multiple sizes need to be supported at the moment, but it could be a roadmap item to provide parameters for that.
| <templates> | ||
| <t | ||
| t-name="Many2ManyBinaryField.attachment_preview" | ||
| t-inherit="web.Many2ManyBinaryField.attachment_preview" |
There was a problem hiding this comment.
Weird that the parent attachment_preview template does not in any way interface with the set of more advanced attachment preview components that are in the mail module. Maybe that's a pending refactor that didn't make the 16.0 release.
There was a problem hiding this comment.
I'd almost think that it's better to make a new widget based on those components, since they have all kinds of size logic already. But that will probably open other cans of worms, so maybe just copy some of the logic to a new getPreviewUrl function and be done with it.
There was a problem hiding this comment.
Maybe that's a pending refactor that didn't make the 16.0 release.
I don't think so
But that will probably open other cans of worms
None that I see, it will just be much more work to migrate this back and forth as the mail components have been refactored/rewritten a lot in the past releases, while the many2many_binary widget has barely changed.
I suggest for version 1 we just use the /web/image controller and expose its parameters (crop, width, height), that will already be very useful. Whenever inline preview should be implemented, we can look into using the mail components for that, but then we're already pretty much on attachment_preview territory and could just make that support images on many2many_binary fields.
This module allows developers to enable a preview on fields displayed
with widget
many2many_binary.Easiest way to test this is to edit the view of mail templates and add the attribute
show_preview="True"which I just did on runboat