-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] web_timeline - support multiple group-by levels and allow to group by m2m field #3006
base: 16.0
Are you sure you want to change the base?
Conversation
Hi @tarteo, |
5a5f65b
to
8cf395a
Compare
Can you please put an screenshot of the feature? |
@pedrobaeza I have included a screenshot of the feature in the PR description. |
Great improvement! |
7e7bc6e
to
e34aeec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
I get an error when I quickly add and remove a group (by double clicking). However if I click normally I don't get an error. There's probably a race condition somewhere
Error (I have assets debugging enabled):
UncaughtPromiseError > TypeError Uncaught Promise > Cannot read properties of undefined (reading 'relation') TypeError: Cannot read properties of undefined (reading 'relation') at Class.split_groups (http://localhost:8069/web/assets/debug/web.assets_backend.js:190546:71) (/web_timeline/static/src/js/timeline_renderer.js:509)
8279013
to
0a27fb8
Compare
@tarteo I cannot reproduce your issue, but I found another related defect and fixed it (error when clicking on the group when group by non-relation field). Could you please help to check again? Thanks. And other things had been done (inthe description). |
For non-technical who wish to test this feature, you can use the XML view arch below to create a timeline view for the project model and modify the project window action to include the timeline view mode for testing. <timeline date_start="date_start" date_stop="date" string="Projects" default_group_by="user_id,partner_id,privacy_visibility" mode="week" event_open_popup="true" stack="true">
<field name="user_id"/>
<field name="privacy_visibility"/>
<field name="tag_ids"/>
<field name="name"/>
<templates>
<t t-name="timeline-item">
<div t-att-title="record.name">
<small>
<div>
<span>
<t t-esc="record.name"/>
</span>
</div>
<div>
PM:
<span>
<t t-esc="record.user_id[1]"/>
</span>
</div>
</small>
</div>
</t>
</templates>
</timeline> |
We added on the scheduled actions the timeline view as demo data for demonstration purposes without requiring extra modules. Maybe you can modify that demo view to showcase this feature. |
0a27fb8
to
f7b6591
Compare
I missed that. Thanks. |
Awesome @cuongnmtm. It would be great to update the version of the addon. |
No, that's done on merge by the bot, when we issue the command. |
f7b6591
to
0bb5942
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional test: LGTM
Allowing to add multiple group-by levels
Test cases: