[MIG] web_edit_user_filter: Migration to 16.0 #2926
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[FIX] Readme [FIX] Lint [ADD] Tests [IMP] UI/UX [IMP] Hide popover when other is opened [IMP] Add item to roadmap
Added translation using Weblate (Chinese (Simplified)) Translated using Weblate (Chinese (Simplified)) Currently translated at 100.0% (3 of 3 strings) Translation: web-12.0/web-12.0-web_edit_user_filter Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_edit_user_filter/zh_CN/ Added translation using Weblate (Croatian) Translated using Weblate (Croatian) Currently translated at 66.7% (2 of 3 strings) Translation: web-12.0/web-12.0-web_edit_user_filter Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_edit_user_filter/hr/ Added translation using Weblate (Portuguese) Translated using Weblate (Portuguese) Currently translated at 100.0% (3 of 3 strings) Translation: web-12.0/web-12.0-web_edit_user_filter Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_edit_user_filter/pt/
has to explicit check for type of value !== null as the typeof null is object https://i.stack.imgur.com/FzI1R.png
Added translation using Weblate (Danish) Translated using Weblate (Danish) Currently translated at 100.0% (3 of 3 strings) Translation: web-12.0/web-12.0-web_edit_user_filter Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_edit_user_filter/da/
Added translation using Weblate (Spanish) Translated using Weblate (Spanish) Currently translated at 100.0% (3 of 3 strings) Translation: web-12.0/web-12.0-web_edit_user_filter Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_edit_user_filter/es/ Added translation using Weblate (French) Translated using Weblate (French) Currently translated at 100.0% (3 of 3 strings) Translation: web-12.0/web-12.0-web_edit_user_filter Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_edit_user_filter/fr/ Added translation using Weblate (Catalan) Translated using Weblate (Catalan) Currently translated at 100.0% (3 of 3 strings) Translation: web-12.0/web-12.0-web_edit_user_filter Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_edit_user_filter/ca/
Added translation using Weblate (Portuguese (Brazil)) Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (3 of 3 strings) Translation: web-12.0/web-12.0-web_edit_user_filter Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_edit_user_filter/pt_BR/
When clicking to edit a filter in search view, the _process_filters function will receive the faceID argument as a string, which will be compared to facet.groupId that is an Integer. Therefore we should use == operator when comparing this value to allow type coercion from JS.
flotho
reviewed
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.