[17.0][MIG] web_chatter_position: Migration to 17.0 #2833
Conversation
|
hey @legalsylvain @chienandalu @CRogos i have closed the previous PR (#2826) and created this new one following every guideline , can you please review? |
|
This does not work at all for me. It breaks My Preferences dialog completely and I have a feeling it breaks other dialogs as well. Teste on fresh clean 17.0 It is compileForm(el, params) function breaking it... |
|
@Rad0van Oh ! its because of the optional chaining |
pandoc-3.2-1-amd64.deb
Outdated
There was a problem hiding this comment.
@MihranThalhath Sorry but what ?
There was a problem hiding this comment.
@Jp-alitec pandoc deb file
There was a problem hiding this comment.
@MihranThalhath Removed it !
Still
There was a problem hiding this comment.
And both commits should be squashed together, or there will be 60 MB of diff
There was a problem hiding this comment.
@pedrobaeza Sqashed / rebase everything according to guidelines
There was a problem hiding this comment.
The binary file is still here.
There was a problem hiding this comment.
@pedrobaeza Where , sorry its not visible to me !
There was a problem hiding this comment.
Now to fix it you need to undo the removal in this commit, put it on a separate one, and then squash with the previous commit (pre-commit auto-fixes)
|
|
mailing module - Because the chatter in mass mailing form view lie under a notebook tab, if user choose sided chatter, it will disappear
Jp-alitec
force-pushed
the
17.0-mig-web_chatter_position
branch
from
8b93b01
to
8412027
Compare
|
@Jp-alitec PR #2795 (comment) Does this have any effect on PR? |
| .o_form_view { | ||
| .o_form_sheet_bg { | ||
| max-width: none; | ||
| } | ||
| .o_form_sheet { | ||
| max-width: $o-form-view-sheet-max-width; | ||
| width: 100%; | ||
| @include media-breakpoint-up(md) { | ||
| margin: $o-sheet-vpadding * 0.2 auto; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
| .o_form_view { | |
| .o_form_sheet_bg { | |
| max-width: none; | |
| } | |
| .o_form_sheet { | |
| max-width: $o-form-view-sheet-max-width; | |
| width: 100%; | |
| @include media-breakpoint-up(md) { | |
| margin: $o-sheet-vpadding * 0.2 auto; | |
| } | |
| } | |
| } | |
| .o_form_view { | |
| .o_form_renderer { | |
| max-width: none; | |
| } | |
| .o_form_sheet_bg { | |
| max-width: none; | |
| .o_form_statusbar { | |
| max-width: $o-form-view-sheet-max-width; | |
| width: 100%; | |
| margin: 0px auto; | |
| } | |
| } | |
| .o_form_sheet { | |
| max-width: $o-form-view-sheet-max-width; | |
| width: 100%; | |
| @include media-breakpoint-up(md) { | |
| margin: $o-sheet-vpadding * 0.2 auto; | |
| }; | |
| @include media-breakpoint-down(sm) { | |
| width: unset !important; | |
| } | |
| } | |
| } |
|
@Jp-alitec In the Invoice view form, I see duplicate chatter, can you fix it? It could be even better. Thank you! |
|
Hi, I tried this module for myself because one my client needs it. It works really well on my end, with no bug. You only have the pre-commit formatting left to do. |
confirmed |
Hi @ryantran-novobi, I am working on fixing the duplicate issue and want to include your suggestion. As I tried, I saw no effect on the form view. Could you please elaborate (nicer with images)? |
Hello everyone, I fixed the issue and prepared this #2893 Please help to review |
|
mhm, oficially OCA module hasn't been migrated, but based on OCA module someone has already published their own version, that seems to work in 17.0 (tho not a single word regarding the usage of OCA module, tho code is 1:1 besides minor changes to form compiler). |
Migrated to V17.