-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] web_tree_many2one_clickable #2780
[17.0][MIG] web_tree_many2one_clickable #2780
Conversation
Clickable many2one fields for tree views ======================================== This addon provides a separate widget to allow many2one fields in a tree view open the linked resource when clicking on their name. You can also define a system parameter to have this behaviour for all the existing many2one fields in tree views. Installation ============ Install it the regular way. Configuration ============= If you want to have all many2one fields clickable by default, you have to define in *Configuration > Technical > Parameters > System parameters*, a new parameter with name `web_tree_many2one_clickable.default` and with value `true`. Usage ===== For the widget option, you need to add `widget="many2one_clickable"` attribute in the XML field definition in the tree view. For example: `<field name="partner_id" widget="many2one_clickable" />` will open the linked partner in a form view. Known issues / Roadmap ====================== * You cannot deactivate clickable behaviour for an specific many2one field if you configure the system parameter. * The value of the system parameter is retrieved for each many2one field present in the view instead of only once.
If a list contains a node which is not a field (e.g. a button), it will not be found in the fields so we'll have an error trying to get 'type' from undefined.
Includes some manual fixes to silent ESLint warnings.
When for instance a form_view_ref context is defined on a field in a specific tree view, the context should also be passed when opening the form.
Clicking on a field with context like this `{'default_product_id': product_id}` doesn't throws an error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I tried this locally and works good.
Could you please squash the bots' commits as shown in https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate?
[MIG] web_tree_many2one_clickable: Migration to 16.0 [MIG] web_tree_many2one_clickable: Migration to 16.0 [MIG] web_tree_many2one_clickable: Migration to 16.0
1f77cf0
to
e2cb859
Compare
Thank you @SirAionTech . Squashed, i hope I got it right 👍 |
Looks like we cannot attach component to Object.assign(ListRenderer.components, {TreeMany2oneClickableButton}); patch(ListRenderer.prototype, {
components: {...ListRenderer.components, TreeMany2oneClickableButton},
} Thus I found a workaround by patching ListRenderer. @SirAionTech , @jaronemo please review again. |
Hi @maciej-wichowski ! I have tried it in runbot and works great. Also I've checked that works on Purchase tree too. Thank you for the PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried on runboat this time, still works good 😄
/ocabot migration web_tree_many2one_clickable |
Sorry @maciej-wichowski you are not allowed to mark the addon tobe migrated. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Code and Functional test both
This PR has the |
/ocabot migration web_tree_many2one_clickable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working correctly on runboat. Just the co-author issue for merging it.
"category": "Hidden", | ||
"website": "https://github.com/OCA/web", | ||
"author": "Therp BV, " | ||
"Tecnativa, " | ||
"Camptocamp, " | ||
"Onestein, " | ||
"Versada, " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This migration doesn't qualify for being co-author. Just add you as contributor.
8b2166a
to
bb2d92a
Compare
Thank you @pedrobaeza , corrected. |
bb2d92a
to
2ce565e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge nobump
2ce565e
to
6334d0a
Compare
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at a480805. Thanks a lot for contributing to OCA. ❤️ |
No description provided.