Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] web_widget_x2many_2d_matrix #2110

Merged
merged 90 commits into from
Feb 18, 2022
Merged

[15.0][MIG] web_widget_x2many_2d_matrix #2110

merged 90 commits into from
Feb 18, 2022

Conversation

ChrisOForgeFlow
Copy link
Contributor

Standard Migration
@ForgeFlow

gaikaz
gaikaz reviewed Feb 4, 2022
View reviewed changes
Copy link
Member

@gaikaz gaikaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review looks good.
I would also like to do a functional review on runboat, but the build is now gone. Should rebuild when you change the version here.
Also, you should probably squash the later commits to the first one named
[15.0][MIG] web_widget_x2many_2d_matrix

web_widget_x2many_2d_matrix/__manifest__.py Outdated Show resolved Hide resolved
@ChrisOForgeFlow
Copy link
Contributor Author

Code review looks good. I would also like to do a functional review on runboat, but the build is now gone. Should rebuild when you change the version here. Also, you should probably squash the later commits to the first one named [15.0][MIG] web_widget_x2many_2d_matrix

Done!, thanks for review

@LoisRForgeFlow LoisRForgeFlow mentioned this pull request Feb 18, 2022
Merged
LoisRForgeFlow
LoisRForgeFlow approved these changes Feb 18, 2022
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works as expected

hbrunn and others added 26 commits February 18, 2022 09:33
@hbrunn @LoisRForgeFlow
[ADD] web_widget_x2many_2d_matrix
79e09dd
@hbrunn @LoisRForgeFlow
[UPD] readme
55fe6c6
@hbrunn @LoisRForgeFlow
[IMP] show column totals in table footer
a6d5482
@hbrunn @LoisRForgeFlow
[FIX] use odoo's parse_value
170c7d9
@hbrunn @LoisRForgeFlow
[ADD] allow to open linked record
9b7870d 
of one of the axes is a many2one field
@hbrunn @LoisRForgeFlow
[IMP] handle readonly flag
08d687b 
[ADD] show grand total
[IMP] classify floats as floats
@hbrunn @LoisRForgeFlow
[IMP] collapse whitespace in rows
6bdb0cd
@hbrunn @LoisRForgeFlow
[IMP] support changing readonly state
5f718fa
@hbrunn @LoisRForgeFlow
[FIX] update readonly value after editing
da1512e
@hbrunn @LoisRForgeFlow
[IMP] pass computed totals to inheriting function
8c2df69
@hbrunn @LoisRForgeFlow
[FIX] replace therp icon
16a289c
@hbrunn @LoisRForgeFlow
[FIX] setup focus
ddb18f4
@hbrunn @LoisRForgeFlow
[ADD] validation
5131dea 
[IMP] write formatted value to back to input
@hbrunn @LoisRForgeFlow
[IMP] we don't need data-x and data-y on the input
59733e8
@hbrunn @LoisRForgeFlow
[IMP] use semantic css classes instead of element names
bea6f42 
[RFR] and being on it, make reacting to changes in overrides simple
@hbrunn @LoisRForgeFlow
[IMP] add screenshot, example in README
e14b376
@hbrunn @LoisRForgeFlow
[IMP] icon
4f34a94
@hbrunn @LoisRForgeFlow
[IMP] better modularity
9ce4562
@hbrunn @LoisRForgeFlow
[FIX] support rerendering after virtual ids change
b2ac1b5 
this is necessary for correct operation after creating new records
@hbrunn @LoisRForgeFlow
[FIX] also reinitialize totals
78ef5f0
@yvaucher @LoisRForgeFlow
Add bug tracker link on README.rst
bf33719
@LoisRForgeFlow
add OCA to author
843a7be
@LoisRForgeFlow
remove comma
465bdc7
@sbidoul @LoisRForgeFlow
[UPD] prefix versions with 8.0
a73771a
@pedrobaeza @LoisRForgeFlow
[MIG] Make modules uninstallable
75c10c5
@hbrunn @LoisRForgeFlow
[IMP] web_widget_x2many_2d_matrix: Several improvements
6d9ec8e 
* README update to newest OCA template
* Example in README
* Massive performance boost for big matrices, specially on Firefox
* Assign id on row in order to find it back in all cases
* Fix OCA#321, choked on cached writes
AdriaGForgeFlow and others added 16 commits February 18, 2022 09:33
@AdriaGForgeFlow @LoisRForgeFlow
[13.0][MIG] web_widget_x2many_2d_matrix
0b44b48
@oca-transbot @LoisRForgeFlow
Update translation files
928f743 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: web-13.0/web-13.0-web_widget_x2many_2d_matrix
Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_widget_x2many_2d_matrix/
@Tardo @LoisRForgeFlow
[IMP] web_widget_x2many_2d_matrix: Debug mode
12cc1e4
@didierdonze @LoisRForgeFlow
Translated using Weblate (German)
a462109 
Currently translated at 100.0% (3 of 3 strings)

Translation: web-13.0/web-13.0-web_widget_x2many_2d_matrix
Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_widget_x2many_2d_matrix/de/
@alexey-pelykh @LoisRForgeFlow
[UPD] Brainbean Apps => CorporateHub
83c3b86
@Saran440 @LoisRForgeFlow
[IMP] web_widget_x2many_2d_matrix: black, isort, prettier
c04bbcb
@Saran440 @LoisRForgeFlow
[14.0][MIG] web_widget_x2many_2d_matrix
1571fd7
@oca-travis @LoisRForgeFlow
[UPD] Update web_widget_x2many_2d_matrix.pot
c4f6f5b
@OCA-git-bot @LoisRForgeFlow
[UPD] README.rst
fa2c005
@bosd @LoisRForgeFlow
Added translation using Weblate (Dutch)
f3bd189
@bosd @LoisRForgeFlow
Translated using Weblate (Dutch)
ac98462 
Currently translated at 33.3% (1 of 3 strings)

Translation: web-14.0/web-14.0-web_widget_x2many_2d_matrix
Translate-URL: https://translation.odoo-community.org/projects/web-14-0/web-14-0-web_widget_x2many_2d_matrix/nl_NL/
@bosd @LoisRForgeFlow
Translated using Weblate (Dutch)
424e050 
Currently translated at 100.0% (3 of 3 strings)

Translation: web-14.0/web-14.0-web_widget_x2many_2d_matrix
Translate-URL: https://translation.odoo-community.org/projects/web-14-0/web-14-0-web_widget_x2many_2d_matrix/nl/
@legalsylvain @LoisRForgeFlow
[FIX] web_widget_x2many_2d_matrix: remove console.log
2ee1c27
@OCA-git-bot @LoisRForgeFlow
web_widget_x2many_2d_matrix 14.0.1.0.1
3069215
@ChrisOForgeFlow @LoisRForgeFlow
[IMP] web_widget_x2many_2d_matrix: black, isort, prettier
9445264
@ChrisOForgeFlow @LoisRForgeFlow
[15.0][MIG] web_widget_x2many_2d_matrix
918f014
@LoisRForgeFlow LoisRForgeFlow force-pushed the 15.0-mig-web_widget_x2many_2d_matrix branch from a0011c3 to 918f014 Compare February 18, 2022 08:34
@LoisRForgeFlow
Copy link
Contributor

@gaikaz commits squashed

@etobella
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-2110-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9216696 into OCA:15.0 Feb 18, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b69172e. Thanks a lot for contributing to OCA. ❤️

@LoisRForgeFlow LoisRForgeFlow deleted the 15.0-mig-web_widget_x2many_2d_matrix branch February 18, 2022 09:28
@gaikaz
Copy link
Member

gaikaz commented Feb 18, 2022

I couldn't get runboat to load a couple of times after the squash. Sorry, for not saying anything.
But I see it just got merged :) Good work then.

@legalsylvain legalsylvain mentioned this pull request Jun 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaikaz gaikaz gaikaz left review comments

@etobella etobella etobella approved these changes

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.