[DO NOT MERGE] Prettier test #1441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Prettier. - Configure ESLint to not conflict with Prettier. - ConfigureESLint to --fix other things.
yajo
added a commit
to Tecnativa/maintainer-quality-tools
that referenced
this pull request
Nov 19, 2019
This commit includes: - Using https://prettier.io/ for supported file formats (these include CSS, SCSS, JS, HTML, MD, YAML and others; see website). - Configure ESLint using `eslint-config-prettier` and removing stylistic checks to avoid conflicts with Prettier. - Add `Promise` as a builtin for v13 (this was missed before, so I take this chance to add that). - Format properly `.travis.yml` so that when it gets merged downstream it gets less diffs when passed trhough Prettier. Some insights: - See OCA/web#1441 as an example of how a web repo looks after this change. - A beta XML Prettier plugin exists, which could be used in the future to autoformat XML files too! - But it's not usable for us right now, as you can see in prettier/plugin-xml#13 (comment) - Once that's fixed, we can use a configuration similar to prettier/plugin-xml#17 (comment) to integrate here.
|
This remains here as an example for OCA/maintainer-quality-tools#618. Go there if you liked it! 😊 |
yajo
added a commit
to Tecnativa/maintainer-quality-tools
that referenced
this pull request
Nov 19, 2019
This commit includes: - Using https://prettier.io/ for supported file formats (these include CSS, SCSS, JS, HTML, MD, YAML and others; see website). - Configure ESLint using `eslint-config-prettier` and removing stylistic checks to avoid conflicts with Prettier. - Add `Promise` as a builtin for v13 (this was missed before, so I take this chance to add that). - Format properly `.travis.yml` so that when it gets merged downstream it gets less diffs when passed trhough Prettier. - Use `eslint --fix` so we get less warnings and more fixes. Some insights: - See OCA/web#1441 as an example of how a web repo looks after this change. - A beta XML Prettier plugin exists, which could be used in the future to autoformat XML files too! - But it's not usable for us right now, as you can see in prettier/plugin-xml#13 (comment) - Once that's fixed, we can use a configuration similar to prettier/plugin-xml#17 (comment) to integrate here.
yajo
added a commit
to Tecnativa/maintainer-quality-tools
that referenced
this pull request
Nov 19, 2019
This commit includes: - Using https://prettier.io/ for supported file formats (these include CSS, SCSS, JS, HTML, MD, YAML and others; see website). - Configure ESLint using `eslint-config-prettier` and removing stylistic checks to avoid conflicts with Prettier. - Add `Promise` as a builtin for v13 (this was missed before, so I take this chance to add that). - Format properly `.travis.yml` so that when it gets merged downstream it gets less diffs when passed trhough Prettier. - Use `eslint --fix` so we get less warnings and more fixes. Some insights: - See OCA/web#1441 as an example of how a web repo looks after this change. - A beta XML Prettier plugin exists, which could be used in the future to autoformat XML files too! - But it's not usable for us right now, as you can see in prettier/plugin-xml#13 (comment) - Once that's fixed, we can use a configuration similar to prettier/plugin-xml#17 (comment) to integrate here.
yajo
added a commit
to Tecnativa/maintainer-quality-tools
that referenced
this pull request
Nov 19, 2019
This commit includes: - Using https://prettier.io/ for supported file formats (these include CSS, SCSS, JS, HTML, MD, YAML and others; see website). - Configure ESLint using `eslint-config-prettier` and removing stylistic checks to avoid conflicts with Prettier. - Add `Promise` as a builtin for v13 (this was missed before, so I take this chance to add that). - Format properly `.travis.yml` so that when it gets merged downstream it gets less diffs when passed trhough Prettier. - Use `eslint --fix` so we get less warnings and more fixes. Some insights: - See OCA/web#1441 as an example of how a web repo looks after this change. - A beta XML Prettier plugin exists, which could be used in the future to autoformat XML files too! - But it's not usable for us right now, as you can see in prettier/plugin-xml#13 (comment) - Once that's fixed, we can use a configuration similar to prettier/plugin-xml#17 (comment) to integrate here.
yajo
added a commit
to Tecnativa/maintainer-quality-tools
that referenced
this pull request
Nov 21, 2019
This commit includes: - Using https://prettier.io/ for supported file formats (these include CSS, SCSS, JS, HTML, MD, YAML and others; see website). - Configure ESLint using `eslint-config-prettier` and removing stylistic checks to avoid conflicts with Prettier. - Add `Promise` as a builtin for v13 (this was missed before, so I take this chance to add that). - Format properly `.travis.yml` so that when it gets merged downstream it gets less diffs when passed trhough Prettier. - Use `eslint --fix` so we get less warnings and more fixes. Some insights: - See OCA/web#1441 as an example of how a web repo looks after this change. - A beta XML Prettier plugin exists, which could be used in the future to autoformat XML files too! - But it's not usable for us right now, as you can see in prettier/plugin-xml#13 (comment) - Once that's fixed, we can use a configuration similar to prettier/plugin-xml#17 (comment) to integrate here.
yajo
added a commit
to Tecnativa/maintainer-quality-tools
that referenced
this pull request
Nov 21, 2019
This commit includes: - Using https://prettier.io/ for supported file formats (these include CSS, SCSS, JS, HTML, MD, YAML and others; see website). - Configure ESLint using `eslint-config-prettier` and removing stylistic checks to avoid conflicts with Prettier. - Add `Promise` as a builtin for v13 (this was missed before, so I take this chance to add that). - Format properly `.travis.yml` so that when it gets merged downstream it gets less diffs when passed trhough Prettier. - Use `eslint --fix` so we get less warnings and more fixes. Some insights: - See OCA/web#1441 as an example of how a web repo looks after this change. - A beta XML Prettier plugin exists, which could be used in the future to autoformat XML files too! - But it's not usable for us right now, as you can see in prettier/plugin-xml#13 (comment) - Once that's fixed, we can use a configuration similar to prettier/plugin-xml#17 (comment) to integrate here.
yajo
added a commit
to Tecnativa/maintainer-quality-tools
that referenced
this pull request
Nov 26, 2019
This commit includes: - Using https://prettier.io/ for supported file formats (these include CSS, SCSS, JS, HTML, MD, YAML and others; see website). - Transform `.eslintrc` (deprecated) to `.eslintrc.yml`, which supports more advanced syntax. - Simplify `.eslintrc.yml` removing disabled checks. All checks are disabled by default anyways. - Remove from `.eslintrc.yml` all stylistic checks that would conflict with Prettier. - Add `Promise` as a builtin for v13 (this was missed before, so I take this chance to add that). - Format properly `.travis.yml` so that when it gets merged downstream it gets less diffs when passed trhough Prettier. - Use `eslint --fix` so we get less warnings and more fixes. Some insights: - See OCA/web#1441 as an example of how a web repo looks after this change. - A beta XML Prettier plugin exists, which could be used in the future to autoformat XML files too! - But it's not usable for us right now, as you can see in prettier/plugin-xml#13 (comment) - Once that's fixed, we can use a configuration similar to prettier/plugin-xml#17 (comment) to integrate here.
yajo
added a commit
to Tecnativa/maintainer-quality-tools
that referenced
this pull request
Nov 28, 2019
This commit includes: - Using https://prettier.io/ for supported file formats (these include CSS, SCSS, JS, HTML, MD, YAML and others; see website). - Transform `.eslintrc` (deprecated) to `.eslintrc.yml`, which supports more advanced syntax. - Simplify `.eslintrc.yml` removing disabled checks. All checks are disabled by default anyways. - Remove from `.eslintrc.yml` all stylistic checks that would conflict with Prettier. - Add `Promise` as a builtin for v13 (this was missed before, so I take this chance to add that). - Format properly `.travis.yml` so that when it gets merged downstream it gets less diffs when passed trhough Prettier. - Use `eslint --fix` so we get less warnings and more fixes. Some insights: - See OCA/web#1441 as an example of how a web repo looks after this change. - A beta XML Prettier plugin exists, which could be used in the future to autoformat XML files too! - But it's not usable for us right now, as you can see in prettier/plugin-xml#13 (comment) - Once that's fixed, we can use a configuration similar to prettier/plugin-xml#17 (comment) to integrate here.
yajo
added a commit
to Tecnativa/maintainer-quality-tools
that referenced
this pull request
Nov 28, 2019
This commit includes: - Using https://prettier.io/ for supported file formats (these include CSS, SCSS, JS, HTML, MD, YAML and others; see website). - Transform `.eslintrc` (deprecated) to `.eslintrc.yml`, which supports more advanced syntax. - Simplify `.eslintrc.yml` removing disabled checks. All checks are disabled by default anyways. - Remove from `.eslintrc.yml` all stylistic checks that would conflict with Prettier. - Add `Promise` as a builtin for v13 (this was missed before, so I take this chance to add that). - Format properly `.travis.yml` so that when it gets merged downstream it gets less diffs when passed trhough Prettier. - Use `eslint --fix` so we get less warnings and more fixes. - Add prettier ignoration tags to README.md template, to avoid double-formatting addons table section. Some insights: - See OCA/web#1441 as an example of how a web repo looks after this change. - A beta XML Prettier plugin exists, which could be used in the future to autoformat XML files too! - But it's not usable for us right now, as you can see in prettier/plugin-xml#13 (comment) - Once that's fixed, we can use a configuration similar to prettier/plugin-xml#17 (comment) to integrate here.
yajo
added a commit
to Tecnativa/maintainer-quality-tools
that referenced
this pull request
Jan 15, 2020
This commit includes: - Using https://prettier.io/ for supported file formats (these include CSS, SCSS, JS, HTML, MD, YAML and others; see website). - Transform `.eslintrc` (deprecated) to `.eslintrc.yml`, which supports more advanced syntax. - Simplify `.eslintrc.yml` removing disabled checks. All checks are disabled by default anyways. - Remove from `.eslintrc.yml` all stylistic checks that would conflict with Prettier. - Add `Promise` as a builtin for v13 (this was missed before, so I take this chance to add that). - Format properly `.travis.yml` so that when it gets merged downstream it gets less diffs when passed trhough Prettier. - Use `eslint --fix` so we get less warnings and more fixes. - Add prettier ignoration tags to README.md template, to avoid double-formatting addons table section. - Ignore for now README.md files to avoid overcomplicating maintenance of those files. Some insights: - See OCA/web#1441 as an example of how a web repo looks after this change. - A beta XML Prettier plugin exists, which could be used in the future to autoformat XML files too! - But it's not usable for us right now, as you can see in prettier/plugin-xml#13 (comment) - Once that's fixed, we can use a configuration similar to prettier/plugin-xml#17 (comment) to integrate here.
yajo
added a commit
to Tecnativa/maintainer-quality-tools
that referenced
this pull request
Jan 15, 2020
This commit includes: - Using https://prettier.io/ for supported file formats (these include CSS, SCSS, JS, HTML, MD, YAML and others; see website). - Transform `.eslintrc` (deprecated) to `.eslintrc.yml`, which supports more advanced syntax. - Simplify `.eslintrc.yml` removing disabled checks. All checks are disabled by default anyways. - Remove from `.eslintrc.yml` all stylistic checks that would conflict with Prettier. - Add `Promise` as a builtin for v13 (this was missed before, so I take this chance to add that). - Format properly `.travis.yml` so that when it gets merged downstream it gets less diffs when passed trhough Prettier. - Use `eslint --fix` so we get less warnings and more fixes. - Add prettier ignoration tags to README.md template, to avoid double-formatting addons table section. - Ignore for now README.md files to avoid overcomplicating maintenance of those files. Some insights: - See OCA/web#1441 as an example of how a web repo looks after this change. - A beta XML Prettier plugin exists, which could be used in the future to autoformat XML files too! - But it's not usable for us right now, as you can see in prettier/plugin-xml#13 (comment) - Once that's fixed, we can use a configuration similar to prettier/plugin-xml#17 (comment) to integrate here.
yajo
pushed a commit
to Tecnativa/maintainer-quality-tools
that referenced
this pull request
Jan 15, 2020
This commit includes: - Using https://prettier.io/ for supported file formats (these include CSS, SCSS, JS, HTML, MD, YAML and others; see website). - Transform `.eslintrc` (deprecated) to `.eslintrc.yml`, which supports more advanced syntax. - Simplify `.eslintrc.yml` removing disabled checks. All checks are disabled by default anyways. - Remove from `.eslintrc.yml` all stylistic checks that would conflict with Prettier. - Add `Promise` as a builtin for v13 (this was missed before, so I take this chance to add that). - Format properly `.travis.yml` so that when it gets merged downstream it gets less diffs when passed trhough Prettier. - Use `eslint --fix` so we get less warnings and more fixes. - Add prettier ignoration tags to README.md template, to avoid double-formatting addons table section. - Ignore for now README.md files to avoid overcomplicating maintenance of those files. Some insights: - See OCA/web#1441 as an example of how a web repo looks after this change. - A beta XML Prettier plugin exists, which could be used in the future to autoformat XML files too! - But it's not usable for us right now, as you can see in prettier/plugin-xml#13 (comment) - Once that's fixed, we can use a configuration similar to prettier/plugin-xml#17 (comment) to integrate here.
yajo
pushed a commit
to Tecnativa/maintainer-quality-tools
that referenced
this pull request
Jan 16, 2020
This commit includes: - Using https://prettier.io/ for supported file formats (these include CSS, SCSS, JS, HTML, MD, YAML and others; see website). - Transform `.eslintrc` (deprecated) to `.eslintrc.yml`, which supports more advanced syntax. - Simplify `.eslintrc.yml` removing disabled checks. All checks are disabled by default anyways. - Remove from `.eslintrc.yml` all stylistic checks that would conflict with Prettier. - Add `Promise` as a builtin for v13 (this was missed before, so I take this chance to add that). - Format properly `.travis.yml` so that when it gets merged downstream it gets less diffs when passed trhough Prettier. - Use `eslint --fix` so we get less warnings and more fixes. - Add prettier ignoration tags to README.md template, to avoid double-formatting addons table section. - Ignore for now README.md files to avoid overcomplicating maintenance of those files. Some insights: - See OCA/web#1441 as an example of how a web repo looks after this change. - A beta XML Prettier plugin exists, which could be used in the future to autoformat XML files too! - But it's not usable for us right now, as you can see in prettier/plugin-xml#13 (comment) - Once that's fixed, we can use a configuration similar to prettier/plugin-xml#17 (comment) to integrate here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just testing some new pre-commit configs, using https://prettier.io/ and
eslint --fix.I'll open another PR in MQT, this is just the showcase of it.
1st commit includes the configuration changes, and 2nd commit is
pre-commig run --all-filesso you see the result.@Tecnativa