-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0] Missing key in search panel filter component OWL #2653
Labels
Comments
Hello @pedrobaeza , can I work on this please? |
Of course! You don't need to ask for permission for contributing 😃 |
Hi @DuyDangHTEN , do you have a specific legacy view tree in mind for me to reproduce the issue? |
view.js
view.xml (Sale for example)
|
idenayer
added a commit
to idenayer/OCA_web
that referenced
this issue
Nov 22, 2023
Fixes OCA#2653 Owl requires the presence of a t-key directive in [t-foreach](https://github.com/odoo/owl/blob/master/doc/reference/templates.md#loops) to be able to properly reconcile renderings. The owl template in `web_responsive/static/src/components/search_panel/search_panel.xml` missed the t-key directive. Hence the crash. This commit introduces this `t-key` and ensures that it is unique.
idenayer
added a commit
to idenayer/OCA_web
that referenced
this issue
Nov 22, 2023
Fixes OCA#2653 Owl requires the presence of a t-key directive in [t-foreach](https://github.com/odoo/owl/blob/master/doc/reference/templates.md#loops) to be able to properly reconcile renderings. The owl template in `web_responsive/static/src/components/search_panel/search_panel.xml` missed the t-key directive. Hence the crash. This commit introduces this `t-key` and ensures that it is unique.
idenayer
added a commit
to idenayer/OCA_web
that referenced
this issue
Nov 22, 2023
Fixes OCA#2653 Owl requires the presence of a t-key directive in [t-foreach](https://github.com/odoo/owl/blob/master/doc/reference/templates.md#loops) to be able to properly reconcile renderings. The owl template in `web_responsive/static/src/components/search_panel/search_panel.xml` missed the t-key directive. Hence the crash. This commit introduces this `t-key` and ensures that it is unique.
idenayer
added a commit
to idenayer/OCA_web
that referenced
this issue
Nov 22, 2023
Fixes OCA#2653 Owl requires the presence of a t-key directive in [t-foreach](https://github.com/odoo/owl/blob/master/doc/reference/templates.md#loops) to be able to properly reconcile renderings. The owl template in `web_responsive/static/src/components/search_panel/search_panel.xml` missed the t-key directive. Hence the crash. This commit introduces this `t-key` and ensures that it is unique.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Module
web_responese
Describe the bug
Missing key in search panel filter component OWL in file:
web_responsive/static/src/components/search_panel/search_panel.xml
<span t-foreach="filters" t-as="filter" class="mx-1">
This cause view with search panel filter raise error missing 't-key'.
UncaughtPromiseError > OwlError Uncaught Promise > "Directive t-foreach should always be used with a t-key!" (expression: t-foreach="filters" t-as="filter")
To Reproduce
Affected versions: 16.0
Expected behavior
Should have 't-key'
<span t-foreach="filters" t-as="filter" t-key="filter.type" class="mx-1">
The text was updated successfully, but these errors were encountered: