Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][BKP] webservice #72

Open
wants to merge 50 commits into
base: 12.0
Choose a base branch
from

Conversation

JordiMForgeFlow
Copy link
Contributor

@JordiMForgeFlow JordiMForgeFlow commented Nov 22, 2024

superseeding OCA/edi#939

etobella and others added 30 commits November 22, 2024 12:04
Currently translated at 85.0% (17 of 20 strings)

Translation: edi-14.0/edi-14.0-webservice
Translate-URL: https://translation.odoo-community.org/projects/edi-14-0/edi-14-0-webservice/fr/
The funtionality is used by the module as the method
`_server_env_fields` is defined, but the inherit of the mixin
using it is missing.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: edi-14.0/edi-14.0-webservice
Translate-URL: https://translation.odoo-community.org/projects/edi-14-0/edi-14-0-webservice/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: edi-15.0/edi-15.0-webservice
Translate-URL: https://translation.odoo-community.org/projects/edi-15-0/edi-15-0-webservice/
'call' now accepts these explicit kw params:

* 'url': to override the request's url completely
* 'url_params': to pass interpolation params for url formatting.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: web-api-16.0/web-api-16.0-webservice
Translate-URL: https://translation.odoo-community.org/projects/web-api-16-0/web-api-16-0-webservice/
Currently translated at 100.0% (43 of 43 strings)

Translation: web-api-16.0/web-api-16.0-webservice
Translate-URL: https://translation.odoo-community.org/projects/web-api-16-0/web-api-16-0-webservice/it/
Currently translated at 100.0% (43 of 43 strings)

Translation: web-api-16.0/web-api-16.0-webservice
Translate-URL: https://translation.odoo-community.org/projects/web-api-16-0/web-api-16-0-webservice/it/
Currently translated at 100.0% (43 of 43 strings)

Translation: web-api-16.0/web-api-16.0-webservice
Translate-URL: https://translation.odoo-community.org/projects/web-api-16-0/web-api-16-0-webservice/it/
oca-ci and others added 17 commits November 22, 2024 12:04
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: web-api-16.0/web-api-16.0-webservice
Translate-URL: https://translation.odoo-community.org/projects/web-api-16-0/web-api-16-0-webservice/
Currently translated at 100.0% (44 of 44 strings)

Translation: web-api-16.0/web-api-16.0-webservice
Translate-URL: https://translation.odoo-community.org/projects/web-api-16-0/web-api-16-0-webservice/it/
when a call is made with just a path, combine it with the collection's url

better combination of urls (Co-authored-by: Simone Orsi <[email protected]>):
Currently translated at 100.0% (44 of 44 strings)

Translation: web-api-16.0/web-api-16.0-webservice
Translate-URL: https://translation.odoo-community.org/projects/web-api-16-0/web-api-16-0-webservice/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: web-api-16.0/web-api-16.0-webservice
Translate-URL: https://translation.odoo-community.org/projects/web-api-16-0/web-api-16-0-webservice/
Currently translated at 100.0% (76 of 76 strings)

Translation: web-api-16.0/web-api-16.0-webservice
Translate-URL: https://translation.odoo-community.org/projects/web-api-16-0/web-api-16-0-webservice/it/
The use of a compute method on ``oauth2_flow`` when this field is touched by
the server environment mixin causes it to be defined twice as computed,
with differents settings, and this ultimately causes a warning message
in the logs:

```
WARNING odoo odoo.modules.registry: webservice.backend: inconsistent 'compute_sudo' for computed fields: protocol, url, auth_type, username, password, api_key, api_key_header, oauth2_flow, oauth2_clientid, oauth2_client_secret, oauth2_token_url, oauth2_authorization_url, oauth2_audience, oauth2_scope, content_type
```

We fix this by overriding method ``compute_server_env()``
Currently translated at 100.0% (76 of 76 strings)

Translation: web-api-16.0/web-api-16.0-webservice
Translate-URL: https://translation.odoo-community.org/projects/web-api-16-0/web-api-16-0-webservice/it/
@JordiMForgeFlow
Copy link
Contributor Author

@simahawk could you check this one?

Copy link

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM

Copy link

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.