-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.0][BKP] webservice #72
base: 12.0
Are you sure you want to change the base?
Conversation
Currently translated at 85.0% (17 of 20 strings) Translation: edi-14.0/edi-14.0-webservice Translate-URL: https://translation.odoo-community.org/projects/edi-14-0/edi-14-0-webservice/fr/
The funtionality is used by the module as the method `_server_env_fields` is defined, but the inherit of the mixin using it is missing.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: edi-14.0/edi-14.0-webservice Translate-URL: https://translation.odoo-community.org/projects/edi-14-0/edi-14-0-webservice/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: edi-15.0/edi-15.0-webservice Translate-URL: https://translation.odoo-community.org/projects/edi-15-0/edi-15-0-webservice/
'call' now accepts these explicit kw params: * 'url': to override the request's url completely * 'url_params': to pass interpolation params for url formatting.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-api-16.0/web-api-16.0-webservice Translate-URL: https://translation.odoo-community.org/projects/web-api-16-0/web-api-16-0-webservice/
Currently translated at 100.0% (43 of 43 strings) Translation: web-api-16.0/web-api-16.0-webservice Translate-URL: https://translation.odoo-community.org/projects/web-api-16-0/web-api-16-0-webservice/it/
Currently translated at 100.0% (43 of 43 strings) Translation: web-api-16.0/web-api-16.0-webservice Translate-URL: https://translation.odoo-community.org/projects/web-api-16-0/web-api-16-0-webservice/it/
Currently translated at 100.0% (43 of 43 strings) Translation: web-api-16.0/web-api-16.0-webservice Translate-URL: https://translation.odoo-community.org/projects/web-api-16-0/web-api-16-0-webservice/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-api-16.0/web-api-16.0-webservice Translate-URL: https://translation.odoo-community.org/projects/web-api-16-0/web-api-16-0-webservice/
Currently translated at 100.0% (44 of 44 strings) Translation: web-api-16.0/web-api-16.0-webservice Translate-URL: https://translation.odoo-community.org/projects/web-api-16-0/web-api-16-0-webservice/it/
when a call is made with just a path, combine it with the collection's url better combination of urls (Co-authored-by: Simone Orsi <[email protected]>):
Currently translated at 100.0% (44 of 44 strings) Translation: web-api-16.0/web-api-16.0-webservice Translate-URL: https://translation.odoo-community.org/projects/web-api-16-0/web-api-16-0-webservice/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-api-16.0/web-api-16.0-webservice Translate-URL: https://translation.odoo-community.org/projects/web-api-16-0/web-api-16-0-webservice/
Currently translated at 100.0% (76 of 76 strings) Translation: web-api-16.0/web-api-16.0-webservice Translate-URL: https://translation.odoo-community.org/projects/web-api-16-0/web-api-16-0-webservice/it/
The use of a compute method on ``oauth2_flow`` when this field is touched by the server environment mixin causes it to be defined twice as computed, with differents settings, and this ultimately causes a warning message in the logs: ``` WARNING odoo odoo.modules.registry: webservice.backend: inconsistent 'compute_sudo' for computed fields: protocol, url, auth_type, username, password, api_key, api_key_header, oauth2_flow, oauth2_clientid, oauth2_client_secret, oauth2_token_url, oauth2_authorization_url, oauth2_audience, oauth2_scope, content_type ``` We fix this by overriding method ``compute_server_env()``
Currently translated at 100.0% (76 of 76 strings) Translation: web-api-16.0/web-api-16.0-webservice Translate-URL: https://translation.odoo-community.org/projects/web-api-16-0/web-api-16-0-webservice/it/
Backport all changes done in v16: https://github.com/OCA/web-api/tree/16.0/webservice
3492694
to
60ab1bb
Compare
60ab1bb
to
4a8168f
Compare
4a8168f
to
ed86d06
Compare
@simahawk could you check this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR has the |
superseeding OCA/edi#939