[MIG] [17.0] hotel reservation #209
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: vertical-hotel-14.0/vertical-hotel-14.0-hotel_reservation Translate-URL: https://translation.odoo-community.org/projects/vertical-hotel-14-0/vertical-hotel-14-0-hotel_reservation/
Currently translated at 62.8% (98 of 156 strings) Translation: vertical-hotel-14.0/vertical-hotel-14.0-hotel_reservation Translate-URL: https://translation.odoo-community.org/projects/vertical-hotel-14-0/vertical-hotel-14-0-hotel_reservation/fr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: vertical-hotel-15.0/vertical-hotel-15.0-hotel_reservation Translate-URL: https://translation.odoo-community.org/projects/vertical-hotel-15-0/vertical-hotel-15-0-hotel_reservation/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: vertical-hotel-15.0/vertical-hotel-15.0-hotel_reservation Translate-URL: https://translation.odoo-community.org/projects/vertical-hotel-15-0/vertical-hotel-15-0-hotel_reservation/
Trivedi-Vacha-SerpentCS
suggested changes
Jun 20, 2024
hotel_reservation/__manifest__.py
Outdated
| { | ||
| "name": "Hotel Reservation Management", | ||
| "version": "17.0.1.0.0", | ||
| "author": "Odoo Community Association (OCA), Serpent Consulting \ |
There was a problem hiding this comment.
Suggested change
| "author": "Odoo Community Association (OCA), Serpent Consulting \ | |
| "author": "Odoo Community Association (OCA), | |
| Serpent Consulting Services Pvt. Ltd., | |
| Odoo S.A", |
hotel_reservation/__manifest__.py
Outdated
| "report/report_view.xml", | ||
| "wizards/hotel_reservation_wizard.xml", | ||
| ], | ||
| # "assets": { |
There was a problem hiding this comment.
remove commented code if not require
| [("reservation_id", "=", folio.reservation_id.id)] | ||
| ) | ||
| if len(reservations) == 1: | ||
| for line in folio.reservation_id.reservation_line: |
There was a problem hiding this comment.
instead of looping each reservation line, update in batch
example:
if len(reservations) == 1:
update_vals = []
for line in folio.reservation_id.reservation_line:
for room in line.reserve:
update_vals.append({
"room_id": room.id,
"check_in": folio.checkin_date,
"check_out": folio.checkout_date,
"state": "assigned",
"reservation_id": folio.reservation_id.id,
})
if update_vals:
reservations.write(update_vals[0])
| reservation_line_obj = self.env["hotel.room.reservation.line"] | ||
| for folio in self: | ||
| reservations = reservation_line_obj.search( | ||
| [("reservation_id", "=", folio.reservation_id.id)] | ||
| ) | ||
| ) |
There was a problem hiding this comment.
no need of this whitespace change.
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated By Raishkhan Pathan
TODO : Need to migrate JS part