-
-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0][MIG] stock_inventory_lockdown #811
[13.0][MIG] stock_inventory_lockdown #811
Conversation
This module is a feature extracted from stock_inventory_location. Ported to v8 and new API Adopted latest OCA standards Added tests
in stock move instead of checks in quants. This will allow for a more robust lockdown, and still make it possible to perform inventory adjustments in the locked location. Also resolves an outstanding issue related to the previous design not allowing inventory adjustments where negative quants existed.
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
The virtual adjustment location may be different from the one provided in property_stock_inventory of the product.
Currently translated at 100.0% (5 of 5 strings) Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_inventory_lockdown Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_inventory_lockdown/zh_CN/
Currently translated at 100.0% (5 of 5 strings) Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_inventory_lockdown Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_inventory_lockdown/pt_BR/
Hey @AdriaGForgeFlow, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and functional review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technical review, LGTM
/ocabot merge |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 4332760. Thanks a lot for contributing to OCA. ❤️ |
"""Refuse changes during exhaustive Inventories""" | ||
|
||
_inherit = "stock.location" | ||
_order = "name" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AdriaGForgeFlow @rousseldenis
Do you know if there is a reason for changing the default order (default is complete_name
)?
It seems pretty brutal. In my case, it makes tests fail in #997
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, I didn't notice it. This is obviously not advised to change _order parameter.
@LoisRForgeFlow @AdriaGForgeFlow Is this needed ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is coming from the creation of this module in v9. I guess it made sense back then but I'm not really sure it is needed anymore, probably not
Standard migration of module stock_inventory_lockdown to v13.
cc ~ @ForgeFlow