Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0] stock_location_bin_name migration to 13.0 #806

Merged
merged 5 commits into from
May 28, 2020

Conversation

guewen
Copy link
Member

@guewen guewen commented Dec 19, 2019

Migrate #713.
Requires #804, #805

@max3903 max3903 added this to the 13.0 milestone Dec 31, 2019
@guewen guewen force-pushed the 13.0-add-stock_location_bin_name branch from f0cf7ee to 9bb4fcd Compare January 7, 2020 06:21
@guewen guewen force-pushed the 13.0-add-stock_location_bin_name branch from 9bb4fcd to 112489b Compare March 17, 2020 10:09
@guewen guewen force-pushed the 13.0-add-stock_location_bin_name branch from 112489b to 380943d Compare March 20, 2020 10:10
@simahawk
Copy link
Contributor

needs rebase + pre-commit update

@guewen
Copy link
Member Author

guewen commented Mar 20, 2020

rebased

"depends": ["stock_location_zone", "stock_location_position"],
"data": ["views/stock_location.xml"],
"installable": True,
"development_status": "Alpha",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still Alpha ?

@simahawk
Copy link
Contributor

@guewen ping on #806 (comment)
Also, required PRs are merged. Can you clean up and make build happy? :)

grindtildeath and others added 5 commits March 30, 2020 12:59
It is not stored because we only need it for the generation of the name.
It slows creation of locations for no value.
If we need to search on it, we can use a search method.
@guewen guewen force-pushed the 13.0-add-stock_location_bin_name branch from 380943d to 3939415 Compare March 30, 2020 11:00
Copy link
Member

@jgrandguillaume jgrandguillaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's merge that

@jgrandguillaume
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-806-by-jgrandguillaume-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 634a392. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 2d2efb0 into OCA:13.0 May 28, 2020
CarlosRoca13 pushed a commit to Tecnativa/stock-logistics-warehouse that referenced this pull request Aug 16, 2021
Signed-off-by jgrandguillaume
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants