Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP][WMS][12.0] stock_minimum_shelf_life #723
[WIP][WMS][12.0] stock_minimum_shelf_life #723
Changes from 2 commits
7b394c8
1bb3e5b
98f8dde
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jgrandguillaume In case of fresh products, isn't it a too big window (days instead) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jgrandguillaume In SAP is documented as 'minimum_remaining_shelf_life'. That would be better understood? Also, why document it at company level? Why not maintain it at product and product category levels?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jgrandguillaume are you sure that this should be limited to stock moves for sales to customers? What about checking it also in production orders, so that you don't accept to consume products that have a certain shelf life limit? This is very important, for example, for food processing.
Al alternative could be that the user defines in settings when they want to check minimum shelf life:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jbeficent I agree with you, this is a very good remark.
Will take this into account.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not so easy because if in pick pack ship setup, then the pick make the reservation.. so it's not a customer one yet..