[WMS][12.0] rework stock_location_zone #711
Conversation
grindtildeath
changed the title
grindtildeath
force-pushed
the
12.0_rework_stock_location_zone
branch
from
550a0e2 to
2731ca8
Compare
|
How fast reaction 😄 👍 |
It prevents other addons to work properly such as the vertical lift. We remove the constraint for now, maybe to be re-introduced later in a more permissive way.
* Compute the 'zone' fields in the same method * Remove the dependency on 'zone_location_id', which seems to take a lot of time if not an infinite loop
So we can use it in group-by and filters. Note that we can have several levels of areas... only the top-level will be used. This commit fixes the computed field dependencies: _compute_location_kind should have a dependency on both it's parent's location_kind and on its child_ids to know if we are in a bin. This can't work without triggering an infinite loop. The trick used here is to split the computation of 'zone_location_id + area_location_id' in one computed method, and move the computation of the kind in a different method with triggers an the current record's zone_location + area_location_id, but not on the parent. Plus the zone_location_id and area_location_id do not depend anymore on the parent's kind, which is the reason for the infinite loop.
|
Reworked the function fields, added |
Co-Authored-By: Jacques-Etienne Baudoux <[email protected]>
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
@jgrandguillaume your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-711-by-jgrandguillaume-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
@rousseldenis your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-711-by-rousseldenis-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 8721632. Thanks a lot for contributing to OCA. ❤️ |
Followup to #653