Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.0] quantity warning on lot with negative number #45

Closed
wants to merge 22 commits into from

Conversation

llacroix
Copy link

No description provided.

'views/stock_move_split.xml',
],
'installable': True,
'application': True,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@llacroix I don't think that this module qualify as an application.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, fixed

@llacroix llacroix force-pushed the 7.0-quantity_warn_on_lot branch from 9ab9a31 to 6e99943 Compare April 22, 2015 19:14
@llacroix llacroix force-pushed the 7.0-quantity_warn_on_lot branch from 6e99943 to fda31b9 Compare April 22, 2015 21:54
@@ -0,0 +1,3 @@
# -*- coding: utf-8 -*-

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright?

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.35%) to 74.57% when pulling 0f43908 on savoirfairelinux:7.0-quantity_warn_on_lot into 5857c35 on OCA:7.0.

product_obj = self.pool.get('product.product')
for data in self.browse(cr, uid, ids, context=context):
for move in move_obj.browse(cr, uid, move_ids, context=context):
product_uom = product_obj.browse(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehdem Why not move.product_uom ?

@ehdem ehdem force-pushed the 7.0-quantity_warn_on_lot branch from 0441fba to 6c44fa8 Compare May 19, 2015 14:42
##############################################################################
import logging

from openerp.osv import orm, osv
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehdem Why import osv?

No need adding the view and just overriding
one method in the StockMoveSplit class
@ehdem ehdem force-pushed the 7.0-quantity_warn_on_lot branch from 6c44fa8 to 9798b45 Compare May 19, 2015 15:25
@yvaucher
Copy link
Member

yvaucher commented Jun 1, 2015

To rebase

@@ -1,3 +1,4 @@
sudo: required
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to remove.

@Cedric-Pigeon
Copy link

@llacroix Hello, do you plan to achieve this PR ? Is it still usefull ? Thanks.

@llacroix
Copy link
Author

@Cedric-Pigeon not planning anything. Can't say if it's useful. Though not for me.

@pedrobaeza pedrobaeza closed this May 30, 2017
gschrott-osi pushed a commit to ursais/stock-logistics-warehouse that referenced this pull request Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants