Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][FIX] stock_helper: fix tests based on modules installed #2220

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

LoisRForgeFlow
Copy link
Contributor

Since this change in v17
odoo/odoo@439ca89 _get_rule fallbacks to location's warehouse to check for routes. This makes that the receipt route is found by _get_source_location_from_route. However, this is the case only with stock module installed, because as soon as mrp or purchase is installed that first step of the receipt route get removed in favor of manufacture or purchase routes. See odoo/odoo@d25d320

cc @MeritxellAForgeFlow

Since this change in v17
odoo/odoo@439ca89
_get_rule fallbacks to location's warehouse to check for routes.
This makes that the receipt route is found by _get_source_location_from_route.
However, this is the case only with `stock` module installed, because
as soon as `mrp` or `purchase` is installed that first step of the receipt
route get removed in favor of manufacture or purchase routes. See
odoo/odoo@d25d320
Copy link

@CarlosVForgeFlow CarlosVForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@MeritxellAForgeFlow MeritxellAForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Lois! LGTM:)

@LoisRForgeFlow
Copy link
Contributor Author

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-2220-by-LoisRForgeFlow-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 69453ca into OCA:17.0 Dec 13, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 68ee66f. Thanks a lot for contributing to OCA. ❤️

@LoisRForgeFlow LoisRForgeFlow deleted the 17.0-fix-stock_helper branch December 13, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants