Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] stock_picking_show_linked: Migration to 18.0 #2219

Open
wants to merge 15 commits into
base: 18.0
Choose a base branch
from

Conversation

fd-oerp
Copy link

@fd-oerp fd-oerp commented Dec 11, 2024

No description provided.

@fd-oerp
Copy link
Author

fd-oerp commented Dec 11, 2024

Hi @rousseldenis

Could you please review this PR and let me know if any changes are needed from my end?

Thank you

@fd-oerp fd-oerp force-pushed the 18.0-mig-stock_picking_show_linked branch from 1ef64ca to c2bc7fe Compare December 11, 2024 20:47
@rousseldenis
Copy link
Contributor

/ocabot migration stock_picking_show_linked

stock_picking_show_linked/models/stock_picking.py Outdated Show resolved Hide resolved
stock_picking_show_linked/models/stock_picking.py Outdated Show resolved Hide resolved
stock_picking_show_linked/models/stock_picking.py Outdated Show resolved Hide resolved
@rousseldenis
Copy link
Contributor

@fd-oerp Shouldn't it be good to get the whole chain or is this intended to show the direct destination and origin pickings ?

@fd-oerp fd-oerp force-pushed the 18.0-mig-stock_picking_show_linked branch from a1babfa to 48edd9a Compare December 12, 2024 15:16
@fd-oerp
Copy link
Author

fd-oerp commented Dec 12, 2024

@fd-oerp Shouldn't it be good to get the whole chain or is this intended to show the direct destination and origin pickings ?

Hi @rousseldenis Thank you for your feedback. As far as I understand, this module is designed to show the direct destination and origin pickings. Please let me know if you believe that it could be improved in any other way.

@rousseldenis
Copy link
Contributor

@fd-oerp Shouldn't it be good to get the whole chain or is this intended to show the direct destination and origin pickings ?

Hi @rousseldenis Thank you for your feedback. As far as I understand, this module is designed to show the direct destination and origin pickings. Please let me know if you believe that it could be improved in any other way.

No, it was intended like that : #1444 (comment)

@fd-oerp
Copy link
Author

fd-oerp commented Dec 12, 2024

@fd-oerp Shouldn't it be good to get the whole chain or is this intended to show the direct destination and origin pickings ?

Hi @rousseldenis Thank you for your feedback. As far as I understand, this module is designed to show the direct destination and origin pickings. Please let me know if you believe that it could be improved in any other way.

No, it was intended like that : #1444 (comment)

Appreciate your input, Thank you

@fd-oerp
Copy link
Author

fd-oerp commented Dec 12, 2024

Hi @LoisRForgeFlow

Could you please review this PR and let me know if any changes are needed from my end ?
Thank you

[18.0][MIG] stock_picking_show_linked: Migration to 18.0
[18.0][MIG] stock_picking_show_linked: Migration to 18.0
[18.0][MIG] stock_picking_show_linked: Migration to 18.0

[18.0][MIG] stock_picking_show_linked: Migration to 18.0

[18.0][MIG] stock_picking_show_linked: Migration to 18.0, suggested improvements

[18.0][MIG] stock_picking_show_linked: Migration to 18.0, improve contributors
@fd-oerp fd-oerp force-pushed the 18.0-mig-stock_picking_show_linked branch from 600d57e to 297798d Compare December 12, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants