Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] procurement_auto_create_group: create a procurement.group for each stock.picking instead of each stock.move #2207

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

ACheung-FactorLibre
Copy link

This update ensures that procurement groups are created at the stock.picking level, rather than at the level of individual stock.move records.

This adjustment improves the grouping logic by associating all stock moves within a single picking under the same procurement group. It prevents unnecessary fragmentation of procurement groups and simplifies the management of pickings and related operations.

@ACheung-FactorLibre ACheung-FactorLibre force-pushed the 16.0-fix-procurement_auto_create_group branch 2 times, most recently from ef19ba9 to abcc090 Compare November 28, 2024 12:54
…ach stock.picking instead of each stock.move
@ACheung-FactorLibre ACheung-FactorLibre force-pushed the 16.0-fix-procurement_auto_create_group branch from abcc090 to bb842c3 Compare November 28, 2024 14:37
@ACheung-FactorLibre ACheung-FactorLibre marked this pull request as ready for review November 28, 2024 15:06
Copy link

@aitoreizmendi aitoreizmendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rousseldenis
Copy link
Contributor

@jbaudoux

Copy link

@LuisNovalio LuisNovalio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Review OK.

Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cannot do that. The purpose is to change the procurement group of the move instead of propagating any existing. It's done at move level to allow to create for example a picking per product to perform pick by product instead of pick by order

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants