Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] stock_quant_task_deferred #2205

Open
wants to merge 2 commits into
base: 16.0
Choose a base branch
from

Conversation

rousseldenis
Copy link
Contributor

@rousseldenis rousseldenis added this to the 16.0 milestone Nov 28, 2024
@jbaudoux
Copy link
Contributor

Cc @sebalix

@rousseldenis rousseldenis force-pushed the 16.0-add-stock-quant-task-deferred-dro branch from f75969f to 2c47b58 Compare November 28, 2024 08:23
@rousseldenis rousseldenis force-pushed the 16.0-add-stock-quant-task-deferred-dro branch from 7dc2c37 to e126ec8 Compare November 28, 2024 13:59
Copy link
Contributor

@sebalix sebalix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: why not using stock.skip_quant_tasks config parameter? (I guess there is a reason)

To not pollute the list of quants for users, we also added a default filter to display only those having quantity != 0. Should it be part of this module as well?

@@ -0,0 +1,2 @@
- Denis Roussel <[email protected]>
- Jacques-Étienne Baudoux <[email protected]>
Copy link
Contributor

@sebalix sebalix Nov 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I should be listed as well? As I gave the idea to J-E (I implemented that for one of our customer).
EDIT: if not I don't really care, happy to see this consolidated in a module :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants