[16.0] [ADD] stock_inventory_security

[ivantodorovich]

In standard, the inventory adjustments can only be applied by Inventory / Manager users.

This module introduces a new security group named Stock: Inventory Adjustments, which
grants regular stock users the ability to apply inventory adjustments.

[yankinmax]

Very nice and well tested, thanks @ivantodorovich

[rousseldenis]

In standard, the inventory adjustments can only be applied by Inventory / Manager users.

This module introduces a new security group named Stock: Inventory Adjustments, which grants regular stock users the ability to apply inventory adjustments.

@ivantodorovich

I suppose you are aware the Odoo standard use case is:

• The inventory users can count the stock levels.
• Then, the manager confirm the counted quantity.

[Camille0907]

Technically LGTM, I just have a few questions

[ivantodorovich]

Indeed, fixed!

[ivantodorovich]

We're essentially testing this:
https://github.com/odoo/odoo/blob/534220ee90da3e213ea99ec5da7ce6cc9eff4203/addons/stock/models/stock_quant.py#L400-L401

[Camille0907]

Sorry, I've just realized that there were a copy/paste issue in my comment : my question was not about search_default_my_count but about with_user(self.env.user) -> So, when do you need the with_user, when don't you ?

[ivantodorovich]

The @users decorator will set the user in self.env.

However, recordsets that were already initialized during setUpClass, referenced in variables like self.product_lot, have their own env set, which isn't modified by the decorator.

So, we need to set the user when interacting with them

[Camille0907]

Okayy thank you for the explanation 👍

[ivantodorovich]

In standard, the inventory adjustments can only be applied by Inventory / Manager users.
This module introduces a new security group named Stock: Inventory Adjustments, which grants regular stock users the ability to apply inventory adjustments.

@ivantodorovich

I suppose you are aware the Odoo standard use case is:

• The inventory users can count the stock levels.
• Then, the manager confirm the counted quantity.

Hello @rousseldenis ,

Indeed. However here we need to grant non-manager users the ability to apply inventories

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖