Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] stock_exception #2063

Open
wants to merge 13 commits into
base: 17.0
Choose a base branch
from
Open

[17.0][MIG] stock_exception #2063

wants to merge 13 commits into from

Conversation

Urvisha-OSI
Copy link
Contributor

No description provided.

@rousseldenis rousseldenis changed the title 17.0 mig stock exception [17.0][MIG] stock_exception Jun 12, 2024
@rousseldenis
Copy link
Contributor

/ocabot migration stock_exception

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jun 12, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 12, 2024
Open
49 tasks
@patrickrwilson patrickrwilson mentioned this pull request Jun 18, 2024
Merged
@Nikul-OSI Nikul-OSI mentioned this pull request Jul 1, 2024
Open
@Nikul-OSI Nikul-OSI force-pushed the 17.0-mig-stock_exception branch from de1e3cc to 2eecda2 Compare July 2, 2024 11:41
@Nikul-OSI
Copy link

@rousseldenis @patrickrwilson Code updated and All checks green. Can you please take a look?

@Nikul-OSI Nikul-OSI force-pushed the 17.0-mig-stock_exception branch from 2eecda2 to 8fe9539 Compare July 3, 2024 04:27
Deriman-Alonso
Deriman-Alonso approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@Deriman-Alonso Deriman-Alonso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

patrickrwilson
patrickrwilson approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@patrickrwilson patrickrwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rousseldenis
rousseldenis reviewed Sep 17, 2024
View reviewed changes
stock_exception/models/stock.py
@@ -43,6 +43,12 @@ def action_confirm(self):
return rec._popup_exceptions()
return super().action_confirm()

def button_validate(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Urvisha-OSI Could you update DESCRIPTION and/or USAGE to reflect this change ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rousseldenis I added a sentence to the Description file.

@mav-adhoc
Copy link
Contributor

LGTM

[UPD] DESCRIPTION.md
536df26 
Adding some more info to the description for when exceptions are checked.
@mav-adhoc
Copy link
Contributor

@Urvisha-OSI Hi! are you going to continue with this migration? Please tell. Thanks!

@mav-adhoc
Copy link
Contributor

@rousseldenis Can i take responsability of migrating this module on another PR?

@patrickrwilson
Copy link
Contributor

@rousseldenis Can i take responsability of migrating this module on another PR?

I'm ok with that to get this over the finish line, I'm not sure why pre-commit is failing so if your PR passes we can go with that one.

@rousseldenis
Copy link
Contributor

@Urvisha-OSI Could you rebase ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickrwilson patrickrwilson patrickrwilson approved these changes

@rousseldenis rousseldenis rousseldenis left review comments

@Deriman-Alonso Deriman-Alonso Deriman-Alonso approved these changes

Assignees
No one assigned
Labels
approved migration needs review
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.