[15.0][IMP]stock_cycle_count: several improvements #1997

ArnauCForgeFlow · 2024-04-17T14:10:39Z

Depends on: #1995

This PR include the following improvements, se commits for more details.

rousseldenis · 2024-05-03T14:35:33Z

stock_cycle_count/models/stock_inventory.py

@@ -76,6 +62,27 @@ def _domain_cycle_count_candidate(self):
            ("location_id", "in", self.location_ids.ids),
        ]

+    def _calculate_inventory_accuracy(self):
+        for inv in self:
+            sml = self.env["stock.move.line"].search(


Mmmh, IMHO this has to be refined has multiple searches will be done...

rousseldenis · 2024-05-29T07:42:06Z

stock_cycle_count/models/stock_cycle_count.py

-                inv.action_state_to_in_progress()
+                try:
+                    inv.action_state_to_in_progress()
+                except Exception as e:


Isn't it a too broad Exception ?

Moreover, shouldn't we manage the exception in a more elegant manner than 'just' logging ?

Hey @rousseldenis

You might be right. I implemented it this way because we don't want the cron job to stop running due to a validation error from a location that already has an inventory adjustment in progress.

Do you have any suggestions for a better approach?

Thanks.

…view

OCA-git-bot · 2024-09-18T09:55:19Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

rousseldenis · 2024-09-18T10:06:46Z

stock_cycle_count/models/stock_cycle_count.py

+            stock_inventory_records = self.mapped("stock_adjustment_ids")
+            for record in stock_inventory_records:
+                if record.responsible_id.id != vals["responsible_id"]:
+                    record.with_context(no_propagate=True).write(


I don't really like such code. Don't you have another mean to avoid this ?

Why not modifying stock_inventory to change the responsible_id fields to computed field (stored/readonly=False) and override the compute here ?

@ArnauCForgeFlow

@rousseldenis, we agree with your proposal and have applied it.
Thank you

…isnt possible

…nverse fields

LoisRForgeFlow · 2024-11-04T12:34:55Z

@rousseldenis friendly reminder here, can you update your last review? @JoanSForgeFlow has attended your request

rousseldenis · 2024-11-04T12:48:07Z

stock_cycle_count/models/stock_quant.py

+                ],
+                order="create_date asc",
+            ).filtered(
+                lambda x: not x.company_id.id


Doesn't it correspond to normal record rule ?

In other words, is the filtered necessary ?

@rousseldenis You are correct, since we are searching for stock move lines by location, and the locations already belong to a company, it is not needed this filter. I'll make the change.

Thanks

@rousseldenis @ArnauCForgeFlow it is not the normal record rule, it is filtering based on the quant company, the normal record rules filters based on the users companies, we cannot rely on the user having the proper companies.

That been said, I think instead of filtering, it can be done with a domain that includes a couple of company_id clauses.

stock_cycle_count/models/stock_move_line.py

…cle_count

ArnauCForgeFlow · 2024-11-28T09:30:06Z

Hey @rousseldenis just a friendly reminder, could you please update your review?

LoisRForgeFlow · 2024-12-03T09:00:37Z

Let's move forward

/ocabot merge major

OCA-git-bot · 2024-12-03T09:00:46Z

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-1997-by-LoisRForgeFlow-bump-major, awaiting test results.

OCA-git-bot · 2024-12-03T09:13:17Z

Congratulations, your PR was merged at 969677c. Thanks a lot for contributing to OCA. ❤️

LoisRForgeFlow · 2024-12-03T09:17:38Z

@ArnauCForgeFlow can you update the 16.0 fwport (#2169) to be fully aligned with this one?

ArnauCForgeFlow force-pushed the 15.0-imp-stock_cycle_count-user_and_date branch 3 times, most recently from 44d4221 to 4c963c0 Compare April 24, 2024 11:14

LoisRForgeFlow mentioned this pull request Apr 24, 2024

[15.0][MIG] stock_cycle_count #1995

Merged

ArnauCForgeFlow force-pushed the 15.0-imp-stock_cycle_count-user_and_date branch 4 times, most recently from ee770b8 to e51735b Compare April 29, 2024 14:42

ArnauCForgeFlow force-pushed the 15.0-imp-stock_cycle_count-user_and_date branch 2 times, most recently from ff64074 to 09edb8a Compare May 2, 2024 15:18

rousseldenis reviewed May 3, 2024

View reviewed changes

ArnauCForgeFlow force-pushed the 15.0-imp-stock_cycle_count-user_and_date branch 6 times, most recently from 09c6757 to be2ca4a Compare May 9, 2024 13:30

JoanSForgeFlow force-pushed the 15.0-imp-stock_cycle_count-user_and_date branch from be2ca4a to 28c1195 Compare May 10, 2024 08:01

rousseldenis reviewed May 29, 2024

View reviewed changes

JoanSForgeFlow force-pushed the 15.0-imp-stock_cycle_count-user_and_date branch 2 times, most recently from 3983318 to 6906e79 Compare June 25, 2024 10:55

ArnauCForgeFlow and others added 6 commits June 27, 2024 13:07

[15.0][IMP] stock_cycle_count: add auto complete into cron

7065ca1

[ADD] stock_cycle_count: line_accuracy in stock move lines

e191484

[IMP] stock_cycle_count: improved inventory_accuracy calculation

ab3986c

[FIX] stock_cyle_count: remove duplicated field location_ids in tree …

232ed7b

…view

[IMP] stock_cycle_count: start inv adjustments depending on setting

bdc8e31

[FIX] stock_cycle_count: prevent creating infinte cycle counts

2e5b1f0

ArnauCForgeFlow force-pushed the 15.0-imp-stock_cycle_count-user_and_date branch from 347ea05 to 2e5b1f0 Compare June 27, 2024 11:14

ArnauCForgeFlow added 2 commits July 22, 2024 13:49

[FIX] stock_cycle_count: prefill_counted_quantity zero, counted, false

3980626

[FIX] stock_cycle_count: inventory adjustment already adds these fields

82bbd01

[IMP] stock_cycle_count: remove auto confirmation logic from the cron

bd1e6a6

JoanSForgeFlow force-pushed the 15.0-imp-stock_cycle_count-user_and_date branch from 3235706 to bd1e6a6 Compare September 18, 2024 09:45

LoisRForgeFlow changed the title ~~[15.0][IMP]stock_cycle_count: add auto complete and begin adjustments in cron~~ [15.0][IMP]stock_cycle_count: several improvements Sep 18, 2024

OCA-git-bot added the ready to merge label Sep 18, 2024

rousseldenis reviewed Sep 18, 2024

View reviewed changes

[FIX] stock_cycle_count: fixed tests since having initial quantity 0 …

cddec1e

…isnt possible

ArnauCForgeFlow mentioned this pull request Oct 3, 2024

[16.0][IMP] stock_cycle_count: some improvements #2169

Merged

[IMP] stock_cycle_count: Refactor responsible_id sync using compute/i…

b8fd2aa

…nverse fields

JoanSForgeFlow force-pushed the 15.0-imp-stock_cycle_count-user_and_date branch from 5a042b4 to b8fd2aa Compare October 22, 2024 14:15

rousseldenis reviewed Nov 4, 2024

View reviewed changes

stock_cycle_count/models/stock_move_line.py Show resolved Hide resolved

[IMP] stock_cycle_count: Remove useless filtered

bbba2f8

JoanSForgeFlow approved these changes Nov 15, 2024

View reviewed changes

JoanSForgeFlow force-pushed the 15.0-imp-stock_cycle_count-user_and_date branch 2 times, most recently from ec684b0 to 34d68ad Compare November 21, 2024 12:03

[FIX] stock_cycle_count: use company of the location when creating cy…

2c9ecf6

…cle_count

JoanSForgeFlow force-pushed the 15.0-imp-stock_cycle_count-user_and_date branch from 34d68ad to 2c9ecf6 Compare November 21, 2024 13:59

[IMP] stock_cycle_count: add rec company_id to domain

cc0320c

OCA-git-bot added the bot is merging ⏳ label Dec 3, 2024

OCA-git-bot merged commit 62df53a into OCA:15.0 Dec 3, 2024
5 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Dec 3, 2024

LoisRForgeFlow deleted the 15.0-imp-stock_cycle_count-user_and_date branch December 3, 2024 09:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[15.0][IMP]stock_cycle_count: several improvements #1997

[15.0][IMP]stock_cycle_count: several improvements #1997

ArnauCForgeFlow commented Apr 17, 2024 •

edited by LoisRForgeFlow

Loading

rousseldenis May 3, 2024

rousseldenis May 29, 2024

ArnauCForgeFlow May 29, 2024

OCA-git-bot commented Sep 18, 2024

rousseldenis Sep 18, 2024

rousseldenis Sep 18, 2024

rousseldenis Oct 7, 2024

JoanSForgeFlow Oct 22, 2024 •

edited

Loading

LoisRForgeFlow commented Nov 4, 2024

rousseldenis Nov 4, 2024

rousseldenis Nov 4, 2024

ArnauCForgeFlow Nov 15, 2024

LoisRForgeFlow Nov 21, 2024

ArnauCForgeFlow commented Nov 28, 2024

LoisRForgeFlow commented Dec 3, 2024

OCA-git-bot commented Dec 3, 2024

OCA-git-bot commented Dec 3, 2024

LoisRForgeFlow commented Dec 3, 2024

[15.0][IMP]stock_cycle_count: several improvements #1997

[15.0][IMP]stock_cycle_count: several improvements #1997

Conversation

ArnauCForgeFlow commented Apr 17, 2024 • edited by LoisRForgeFlow Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OCA-git-bot commented Sep 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JoanSForgeFlow Oct 22, 2024 • edited Loading

Choose a reason for hiding this comment

LoisRForgeFlow commented Nov 4, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ArnauCForgeFlow commented Nov 28, 2024

LoisRForgeFlow commented Dec 3, 2024

OCA-git-bot commented Dec 3, 2024

OCA-git-bot commented Dec 3, 2024

LoisRForgeFlow commented Dec 3, 2024

ArnauCForgeFlow commented Apr 17, 2024 •

edited by LoisRForgeFlow

Loading

JoanSForgeFlow Oct 22, 2024 •

edited

Loading