[14.0][IMP] stock_reserve: Substract Forecasted Quantity from products according to configuration option #1859
Conversation
There was a problem hiding this comment.
Seeing the tests, it seems the initial intention is that the quantities to be substracted from the forecasted quantity which I don't see before.
This is something reasonable for reservation in sales quotations, where you want to already have less quantity. There are 2 ways then:
- Add an option to substract or not, global by company or per reservation (this second one is more flexible, but more difficult to be implemented).
- Do this for our custom case apart from the standard OCA, as we will have only the case of not substracting.
I think we are going to the point 2 in this occasion.
…rding to configuration option TT43413
victoralmau
force-pushed
the
14.0-fix-stock_reserve-TT43413
branch
from
005b430 to
d2a8906
Compare
victoralmau
changed the title
|
Changes done. |
| :target: https://runboat.odoo-community.org/builds?repo=OCA/stock-logistics-warehouse&target_branch=14.0 | ||
| :alt: Try me on Runboat | ||
| .. |badge5| image:: https://img.shields.io/badge/runbot-Try%20me-875A7B.png | ||
| :target: https://runbot.odoo-community.org/runbot/153/14.0 |
There was a problem hiding this comment.
You have an outdated README generator. Please update your local maintainer-tools installation
| """Add location reservation for avoiding reservations to be substracted on | ||
| the forecasted quantity. | ||
| """ | ||
| company = self.company_id or self.env.company |
There was a problem hiding this comment.
This is not valid, as products by default don't have company, so this is always going to take the main company, which is not what is needed, specially on things coming from OdooBot. Argument company_id is not filled? If any doubt about the company passed, please go back to what I asked to put this on custom.
There was a problem hiding this comment.
Ok, taking into account what you indicate, we add this to custom (subtract always) and leave this PR to implement option 1 (more difficult to implement)
There was a problem hiding this comment.
But it won't be valid if the company is not perfectly guessed.
There was a problem hiding this comment.
With option 1 yes: Define for each reservation whether to subtract or not (auto-defining the value of a new field according to the company configuration), but the filter to be performed would be more complex than just by location.
|
Let's abort this, as it's not easily done. |
Substract Forecasted Quantity from products according to configuration option.
Example use case:
Please @pedrobaeza can you review it?
@Tecnativa TT43413