Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX] stock_location_orderpoint_source_relocate #1847

Merged
merged 2 commits into from
Jun 16, 2024
Merged

[14.0][FIX] stock_location_orderpoint_source_relocate #1847

merged 2 commits into from
Jun 16, 2024

Conversation

jbaudoux
Copy link
Contributor

@jbaudoux jbaudoux commented Sep 18, 2023 •
edited
Loading

Check orderpoints also for non relocated moves
Fix quantity to replenish in case of partial relocation (move partially available)

Depends on:

cc @mt-software-de @rousseldenis

@OCA-git-bot
Copy link
Contributor

Hi @mt-software-de,
some modules you are maintaining are being modified, check this out!

@jbaudoux jbaudoux force-pushed the 14-fix-location_orderpoint_source_relocate branch 7 times, most recently from 367600e to d9b0d0e Compare September 18, 2023 20:58
@jbaudoux jbaudoux mentioned this pull request Sep 19, 2023
Merged
@jbaudoux jbaudoux force-pushed the 14-fix-location_orderpoint_source_relocate branch from 1f2392e to c969825 Compare September 19, 2023 14:07
@jbaudoux
[FIX] stock_location_orderpoint: tests
823c177 
Make setup methods as classmethod
@jbaudoux jbaudoux force-pushed the 14-fix-location_orderpoint_source_relocate branch from c969825 to c869e6d Compare September 19, 2023 14:23
@mt-software-de
Copy link
Contributor

Could you push your latest commits?

@mt-software-de
Copy link
Contributor

Could you push your latest commits?
Ok the merge of OCA/wms#755 failed. thats why the tests are failing

mt-software-de
mt-software-de approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@mt-software-de mt-software-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor remarks. LGTM

stock_location_orderpoint_source_relocate/tests/test_location_orderpoint.py Outdated
Comment on lines 45 to 48
cls._create_incoming_move(10, cls.replenishment_location)

def test_auto_replenishment_without_relocation(self):
job_func = self.env["stock.location.orderpoint"].run_auto_replenishment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cls._create_incoming_move(10, cls.replenishment_location)
def test_auto_replenishment_without_relocation(self):
job_func = self.env["stock.location.orderpoint"].run_auto_replenishment
cls._create_incoming_move(10, cls.replenishment_location)
cls.job_func = cls.env["stock.location.orderpoint"].run_auto_replenishment
def test_auto_replenishment_without_relocation(self):
job_func = self.job_func

Could you move this also to the setUpClass?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jbaudoux
[FIX] stock_location_orderpoint
15b7ac7 
Check orderpoints also for non relocated moves
Fix quantity to replenish in case of partial source relocation
@jbaudoux jbaudoux force-pushed the 14-fix-location_orderpoint_source_relocate branch from c869e6d to 15b7ac7 Compare October 4, 2023 06:59
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 12, 2024
@github-actions github-actions bot closed this Jun 16, 2024
@jbaudoux jbaudoux reopened this Jun 16, 2024
@OCA-git-bot
Copy link
Contributor

Hi @mt-software-de,
some modules you are maintaining are being modified, check this out!

@jbaudoux
Copy link
Contributor Author

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-1847-by-jbaudoux-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7df12a0 into OCA:14.0 Jun 16, 2024
8 of 11 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 400db83. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mt-software-de mt-software-de mt-software-de approved these changes

Assignees
No one assigned
Labels
merged 🎉 stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbaudoux @OCA-git-bot @mt-software-de