[14.0][FIX] stock_location_package_restriction for backorder #1797
Conversation
| @@ -31,8 +31,9 @@ def _check_location_package_restriction(self): | |||
| location_packages = { | |||
| g["location_id"][0]: set(g["package_id"]) for g in quants_grouped | |||
| } | |||
| lines_being_processed = self.move_line_ids.filtered(lambda line: line.qty_done) | |||
There was a problem hiding this comment.
@TDu Is this working when not using the detailed operations and quantity_done directly on stock.move ?
There was a problem hiding this comment.
Thanks for your review and the answer is no, it is not working...
There was a problem hiding this comment.
It should also work as there are always move lines. See https://github.com/odoo/odoo/blob/14.0/addons/stock/models/stock_move.py#L358
There was a problem hiding this comment.
My quick test was changing the unit test to update the quantity done on the stock.move instead of the move line.
And it failed with
A package is mandatory on the location BWH/Stock/TestLocation2. You cannot move the product Wood without a package
Which does not seem related to your question.
|
I have added options on the check function that I need from another PR. |
Only check the restriction for moves actually being done.
TDu
force-pushed
the
14-location-pack-restriction-backorder
branch
from
3047463 to
de01825
Compare
|
Rebased |
|
@rousseldenis Good for you ? |
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 92384a0. Thanks a lot for contributing to OCA. ❤️ |
Only check the restriction for moves actually being done.