Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

]16.0][MIG] stock_inventory #1666

Closed
wants to merge 7 commits into from

Conversation

Urvisha-OSI
Copy link
Contributor

No description provided.

@Urvisha-OSI Urvisha-OSI changed the title 16.0 mig stock inventory ]16.0][MIG] stock_inventory Mar 22, 2023
@rousseldenis
Copy link
Contributor

@Urvisha-OSI Thanks for this.

Could you put pre-commit modifications (like setup) in a separate commit as explained here https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0 ?

@rousseldenis
Copy link
Contributor

/ocabot migration stock_inventory

}
)
self.location2 = self.location_model.create(
{
"name": "Location 2",
"usage": "internal",
"location_id": self.location_src.id,
"location_id": self.location_dst.id,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why changing location 2 (internal) to a customer location ???

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexPForgeFlow
Copy link
Contributor

AlexPForgeFlow commented Sep 20, 2023

Hi @Urvisha-OSI, when doing the #1849, tests failed because in stock_inventory is trying to modify a field that is not allowed by odoo base. In the stock_quant.py file of your module I would add:
def _get_inventory_fields_write(self):
return super()._get_inventory_fields_write() + ["to_do"]
To make sure that you can modify this field, I have test it locally and it works you can see the changes for v15 be501a4.

Also I did a fix in v15, see the commit (ForgeFlow@264bc7c) also it is present in the #1848 , can you add the changes?

@rousseldenis
Copy link
Contributor

@Urvisha-OSI I will supersedes this with fixes by @AlexPForgeFlow

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 11, 2024
@github-actions github-actions bot closed this Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate migration needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants