[15.0][MIG] stock_orderpoint_generator: Migration to 15.0 #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#258) And improve the wording * Add an option to automatically generate rules When a product variant is created with a (or several) rule template(s), it automatically generates (on the fly) the corresponding rule(s). When a rule template is modified, it automatically updates the existing rules of the linked products (it uses the mechanism in place, disable the old and create a fresh one). The latter update is done by a cron because it might take a long time to update all the products reordering rules. * Add documentation * Copy orderpoint views to orderpoint templates Unfortunately we cannot rely on the possibility to copy a view with "inherit_id" + "mode=primary" in Odoo 9.0 in this use case (precisely with a model that is a "copy by prototype"). The explanation: We "copy by prototype" the model "stock.warehouse.orderpoint" to a new "stock.warehouse.orderpoint.template" model (with both _inherit and different _name). Before this commit, we were reusing the stock.warehouse.orderpoint's views, just making the changes needed for the templates. Thing is: when a third (unrelated) addon adds a column on the model, the ORM doesn't add the column in the stock.warehouse.orderpoint.template model. So the templates' views complains about this unexisting field. Therefore, copy-pasting the view ensure that changes on 'stock.warehouse.orderpoint' does not have any side effect on the templates. From Odoo 10.0, the "copy by prototype" reports the changes made on the "prototype" model to the "copy" so we should be able to revert to the "inherit_id" + "mode=primary" views.
Currently translated at 50.7% (38 of 75 strings) Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_orderpoint_generator Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_orderpoint_generator/sl/
With initial wrong values we can carry a computing error to the subsequent moves.
A new option for auto computing minimum and maximum values depending on the actual delivered items for a period of time
chienandalu
force-pushed
the
15.0-mig-stock_orderpoint_generator
branch
2 times, most recently
from
a2b86f4 to
d9bb573
Compare
chienandalu
force-pushed
the
15.0-mig-stock_orderpoint_generator
branch
from
d9bb573 to
38ed109
Compare
|
@chienandalu Still draft ? |
|
No, it's ready for review. Thanks :) |
chienandalu
force-pushed
the
15.0-mig-stock_orderpoint_generator
branch
from
38ed109 to
d2d0c80
Compare
|
/ocabot migration stock_orderpoint_generator |
chienandalu
force-pushed
the
15.0-mig-stock_orderpoint_generator
branch
from
d2d0c80 to
313e197
Compare
|
All fixed @rousseldenis |
| ("location_id", "=", self.location_id.id), | ||
| ("company_id", "=", self.company_id.id), | ||
| ] | ||
| ).unlink() |
There was a problem hiding this comment.
This is a change in the module behavior. @yvaucher
There was a problem hiding this comment.
Yes, there's a unique key constraint for product, location_id, company_id that won't let us simply archive them. So we can only delete the old ones.
pedrobaeza
changed the title
|
This PR has the |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at d604838. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TT36996 cc @Tecnativa