-
-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][MIG]stock_inventory_exclude_sublocation #1574
[15.0][MIG]stock_inventory_exclude_sublocation #1574
Conversation
* [ADD] stock_inventory_exclude_sublocation
…nly editable in draft state
It also includes the removal of an unneeded dependency + better position of the field in view
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_inventory_exclude_sublocation Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_inventory_exclude_sublocation/
Currently translated at 100.0% (2 of 2 strings) Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_inventory_exclude_sublocation Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_inventory_exclude_sublocation/pt_BR/
Currently translated at 100.0% (2 of 2 strings) Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_inventory_exclude_sublocation Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_inventory_exclude_sublocation/zh_CN/
…ts, only assign rights to demo user
Currently translated at 100.0% (2 of 2 strings) Translation: stock-logistics-warehouse-14.0/stock-logistics-warehouse-14.0-stock_inventory_exclude_sublocation Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-14-0/stock-logistics-warehouse-14-0-stock_inventory_exclude_sublocation/it/
/ocabot migration stock_inventory_exclude_sublocation Same remarks as in #1573 |
fc3c204
to
12814fd
Compare
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Can some one reopen this pull request? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The migration does not look correct, you are changing all tests to expect what you are getting instead of fixing the code to do what was expected by the module
starting_inv.action_start() | ||
starting_inv.action_validate() | ||
with self.assertRaises(ValidationError): | ||
starting_inv.action_state_to_in_progress() | ||
starting_inv.action_state_to_done() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here
inventory_location.action_start() | ||
inventory_location.action_validate() | ||
lines = inventory_location.line_ids | ||
self.assertEqual(len(lines), 2, "Not all expected products are " "included") | ||
with self.assertRaises(ValidationError): | ||
inventory_location.action_state_to_in_progress() | ||
inventory_location.action_state_to_done() | ||
lines = inventory_location.stock_quant_ids | ||
with self.assertRaises(AssertionError): | ||
self.assertEqual(len(lines), 2, "Not all expected products are " "included") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here
with self.assertRaises(ValidationError): | ||
inventory_location.action_state_to_in_progress() | ||
inventory_location.action_state_to_done() | ||
with self.assertRaises(ValidationError): | ||
inventory_sublocation.action_state_to_in_progress() | ||
inventory_sublocation.action_state_to_done() | ||
lines_location = inventory_location.stock_quant_ids | ||
lines_sublocation = inventory_sublocation.stock_quant_ids | ||
with self.assertRaises(AssertionError): | ||
self.assertEqual( | ||
len(lines_location), | ||
1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here
The functionality of this module has been included in the base module after this PR #1991. So we can close this one now. |
Depends on #1512