Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG]stock_inventory_exclude_sublocation #1574

Conversation

Chanakya-OSI
Copy link
Contributor

@Chanakya-OSI Chanakya-OSI commented Dec 8, 2022

Depends on #1512

LoisRForgeFlow and others added 30 commits December 8, 2022 14:45
* [ADD] stock_inventory_exclude_sublocation
It also includes the removal of an unneeded dependency + better position of the field in view
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_inventory_exclude_sublocation
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_inventory_exclude_sublocation/
Currently translated at 100.0% (2 of 2 strings)

Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_inventory_exclude_sublocation
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_inventory_exclude_sublocation/pt_BR/
Currently translated at 100.0% (2 of 2 strings)

Translation: stock-logistics-warehouse-12.0/stock-logistics-warehouse-12.0-stock_inventory_exclude_sublocation
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_inventory_exclude_sublocation/zh_CN/
@rousseldenis
Copy link
Contributor

/ocabot migration stock_inventory_exclude_sublocation

Same remarks as in #1573

@Chanakya-OSI Chanakya-OSI force-pushed the 15.0_mig_stock_inventory_exclude_sublocation branch from fc3c204 to 12814fd Compare December 12, 2022 13:44
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 14, 2023
@github-actions github-actions bot closed this Jun 18, 2023
@mileo
Copy link
Member

mileo commented Jan 17, 2024

Can some one reopen this pull request?

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The migration does not look correct, you are changing all tests to expect what you are getting instead of fixing the code to do what was expected by the module

Comment on lines 83 to 82
starting_inv.action_start()
starting_inv.action_validate()
with self.assertRaises(ValidationError):
starting_inv.action_state_to_in_progress()
starting_inv.action_state_to_done()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here

Comment on lines 102 to 105
inventory_location.action_start()
inventory_location.action_validate()
lines = inventory_location.line_ids
self.assertEqual(len(lines), 2, "Not all expected products are " "included")
with self.assertRaises(ValidationError):
inventory_location.action_state_to_in_progress()
inventory_location.action_state_to_done()
lines = inventory_location.stock_quant_ids
with self.assertRaises(AssertionError):
self.assertEqual(len(lines), 2, "Not all expected products are " "included")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here

Comment on lines +116 to +127
with self.assertRaises(ValidationError):
inventory_location.action_state_to_in_progress()
inventory_location.action_state_to_done()
with self.assertRaises(ValidationError):
inventory_sublocation.action_state_to_in_progress()
inventory_sublocation.action_state_to_done()
lines_location = inventory_location.stock_quant_ids
lines_sublocation = inventory_sublocation.stock_quant_ids
with self.assertRaises(AssertionError):
self.assertEqual(
len(lines_location),
1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 21, 2024
@LoisRForgeFlow
Copy link
Contributor

The functionality of this module has been included in the base module after this PR #1991. So we can close this one now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.