Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][PORT] stock_location_tray: Porting from 14.0 to 15.0 #1568

Closed

Conversation

GabbasovDinar
Copy link
Member

No description provided.

guewen and others added 20 commits December 4, 2022 18:40
Extracted from stock_vertical_lift
(OCA#633)

Add tray types to stock locations, automatically generates
sub-locations. Present them nicely with a custom widget.
Use the multi creation on records to create all the xmlids at once.


There is change in odoo/odoo for both 13.0 and 14.0 at
odoo/odoo@b6ba603#diff-0b83f13eeb39606e0cc2ebe1443b40c01c19bf49ec16ab100dbcb0d0f4c9e4b6R99-R106.
With the change, `UserError(_('You still have some product in locations
%s')` is always risen before the two `ValidationError(_("Tray locations
cannot be archived when they contain products.")` and
`UserError(_("Trays cannot be modified when they contain products.")` of
this module. Therefor, the OCA#987 changes tests to meet that flow change.

To prove the dead code, we have two hacks: change context to bypass
odoo/odoo checking as
OCA@79fa705#diff-ce46c42b625b31fbfc9cd2646ccfe9d647a894001a331cd54d3ce0cf04b466a3R161-R163
and
OCA@79fa705#diff-ce46c42b625b31fbfc9cd2646ccfe9d647a894001a331cd54d3ce0cf04b466a3R183-R187.
We believe that in daily use, there is no hack like that.
@rousseldenis
Copy link
Contributor

/ocabot migration stock_location_tray

@GabbasovDinar Thanks for this. Could you check your commit user (diga) as it seems not associated with your github account (GabbasovDinar) ?

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Dec 5, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 5, 2022
80 tasks
@GabbasovDinar GabbasovDinar force-pushed the 15.0-porting-oca-stock-logistics-warehouse branch from bac1a69 to 2c179c6 Compare December 6, 2022 16:16
@rousseldenis
Copy link
Contributor

@GabbasovDinar Don't forget to follow migration guide https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0

Especially commit name (that should reflect a 'migration')

@rousseldenis
Copy link
Contributor

/ocabot migration stock_location_tray

@GabbasovDinar GabbasovDinar force-pushed the 15.0-porting-oca-stock-logistics-warehouse branch from 2c179c6 to b6b3ff0 Compare December 21, 2022 01:44
@Aldeigja
Copy link

Aldeigja commented Jan 2, 2023

@OCA/logistics-maintainers-psc-representative could you review?

@github-actions
Copy link

github-actions bot commented May 7, 2023

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 7, 2023
@github-actions github-actions bot closed this Jun 11, 2023
@GabbasovDinar
Copy link
Member Author

How to reopen this PR?

@rousseldenis
Copy link
Contributor

How to reopen this PR?

@GabbasovDinar Unfortiunately, you need to open a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.