Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] stock_lot_filter_available: Migration to version 15.0 #1523

Merged
merged 4 commits into from
Nov 9, 2022

Conversation

CarlosRoca13
Copy link
Contributor

cc @Tecnativa TT36554

please @carlosdauden @victoralmau review this

@CarlosRoca13 CarlosRoca13 force-pushed the 15.0-MIG-stock_lot_filter_available branch from a3633ed to 37a0e6b Compare October 27, 2022 10:59
cls.company = cls.env.ref("base.main_company")
cls.loc = cls.env.ref("stock.stock_location_stock")
cls.product = cls.env["product.product"].create(
{"name": "Test product", "type": "product", "tracking": "lot"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{"name": "Test product", "type": "product", "tracking": "lot"}
{"name": "Test product", "detailed_type": "product", "tracking": "lot"}

@CarlosRoca13 CarlosRoca13 force-pushed the 15.0-MIG-stock_lot_filter_available branch from 37a0e6b to aab1fb9 Compare October 27, 2022 11:20
@CarlosRoca13
Copy link
Contributor Author

@victoralmau Changed!

Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functionality OK

@pedrobaeza
Copy link
Member

/ocabot migration stock_lot_filter_available
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Nov 8, 2022
@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-1523-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 8, 2022
Signed-off-by pedrobaeza
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 8, 2022
80 tasks
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-1523-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-1523-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-1523-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 8, 2022
Signed-off-by pedrobaeza
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-1523-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 9, 2022
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 15.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 15.0-ocabot-merge-pr-1523-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3fca59a into OCA:15.0 Nov 9, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 53cf220. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants