[MIG] stock_reserve_sale 15.0 #1486

flachica · 2022-09-15T10:37:27Z

Dependencies:

…_reserve and stock_reserve_sale.

before running the tests. This fixes the failure experienced when running the test in --init mode rather than --update mode.

victoralmau · 2022-09-28T07:18:15Z

Please, cherry-pick #1489

flachica · 2022-09-28T08:32:25Z

@victoralmau Forgive my ignorance, how do I apply the cherry-pick?

flachica · 2022-09-28T13:41:14Z

@victoralmau I think that I included your #1489 correctly

TT39113

oca-clabot · 2022-09-28T13:46:11Z

Hey @flachica, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla
Here is a list of the users:

Alexandre MOREAU [email protected] (no github login found)
Ismael Calvo [email protected] (no github login found)

Appreciation of efforts,
OCA CLAbot

victoralmau · 2022-09-28T13:55:33Z

@victoralmau I think that I included your #1489 correctly

Ok, it's well done.
When the stock_reserve addon is merged, we can continue with this migration.

rousseldenis · 2022-10-11T08:31:19Z

@flachica FYI, you can, if you want to tests succeed, add a line in test-requirements.txt file with the addon this PR depends on.

Like :

odoo-addon-stock-reserve @ git+https://github.com/OCA/stock-logistics-warehouse.git@refs/pull/1484/head#subdirectory=setup/stock_reserve

That commit should be then removed after the other PR merging.

flachica · 2022-10-11T11:09:25Z

@flachica FYI, you can, if you want to tests succeed, add a line in test-requirements.txt file with the addon this PR depends on.

Like :

odoo-addon-stock-reserve @ git+https://github.com/OCA/stock-logistics-warehouse.git@refs/pull/1484/head#subdirectory=setup/stock_reserve

That commit should be then removed after the other PR merging.

Bad news. Tests was failing

rousseldenis · 2022-10-11T11:23:39Z

test-requirements.txt

@@ -0,0 +1 @@
+odoo-addon-stock-reserve @ git+https://github.com/OCA/stock-logistics-warehouse.git@refs/pull/1484/head#subdirectory=setup/stock_reserve


Suggested change

odoo-addon-stock-reserve @ git+https://github.com/OCA/stock-logistics-warehouse.git@refs/pull/1484/head#subdirectory=setup/stock_reserve

odoo-addon-stock-reserve @ git+https://github.com/OCA/stock-logistics-warehouse.git@refs/pull/1485/head#subdirectory=setup/stock_reserve

Link to good PR should work 😃

Still failling. I tried your suggestion and other change but I can't solve this.

Thanks

Please use suggested syntax. Yours is not correct

Thanks for your response but, as I commented before, I tryied your suggestion but still failing

I don't find any example. Sorry. Where I can find documentation to read about this?

@flachica Not the same error.

Here this is about your module tests. Not not found module.

The error about unreleased dependencies is normal. It should be solved before merging this (as the base module is merged).

The difference here is you have a runboat running that allows to do functional tests

Wow, impressive. I love the functionality. Thanks so much for the help

This commit must be ignored in Odoo Bot merge action

CasVissers-360ERP

Initial functional review

CasVissers-360ERP · 2022-11-25T10:46:18Z

stock_reserve_sale/model/sale.py

+    has_stock_reservation = fields.Boolean(
+        compute="_compute_stock_reservation",
+        readonly=True,
+        multi="stock_reservation",


Field sale.order.has_stock_reservation: unknown parameter 'multi', if this is an actual parameter you may want to override the method _valid_field_parameter on the relevant model in order to allow it

CasVissers-360ERP · 2022-11-25T10:46:30Z

stock_reserve_sale/model/sale.py

+    is_stock_reservable = fields.Boolean(
+        compute="_compute_stock_reservation",
+        readonly=True,
+        multi="stock_reservation",


Field sale.order.is_stock_reservable: unknown parameter 'multi', if this is an actual parameter you may want to override the method _valid_field_parameter on the relevant model in order to allow it

CasVissers-360ERP · 2022-11-25T10:48:25Z

stock_reserve_sale/wizard/sale_stock_reserve.py

+
+
+class SaleStockReserve(models.TransientModel):
+    _name = "sale.stock.reserve"


You are not allowed to access 'Sale Stock Reserve' (sale.stock.reserve) records.

Missing access rights

CasVissers-360ERP · 2022-11-25T10:51:33Z

stock_reserve_sale/view/sale.xml

+                    help="Pre-book products from stock"
+                    attrs="{'invisible': [('is_stock_reservable', '=', False)]}"
+                />
+            </button>


A smartbutton to view reservations would be a nice addition

CasVissers-360ERP · 2022-11-25T10:53:04Z

stock_reserve_sale/wizard/sale_stock_reserve.py

+            lines = model.browse(self.env.context["active_ids"])
+
+        try:
+            owners = {line.stock_owner_id for line in lines}


Fetching owner from order is not working

CasVissers-360ERP · 2022-11-29T13:53:52Z

stock_reserve_sale/model/sale.py

+            return rule.procure_method
+        return False
+
+    @api.depends("state", "product_id.route_ids", "product_id.type")


type = detailed_type

CasVissers-360ERP · 2022-11-29T13:57:59Z

stock_reserve_sale/view/sale.xml

+                <div class="text-right">
+                    <button
+                        name="release_all_stock_reservation"
+                        string="Cancell all"


CasVissers-360ERP · 2022-11-29T13:58:34Z

@flachica The code quality is low, I am going to pause my review.

github-actions · 2023-04-09T12:25:30Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

rvalyi · 2023-04-25T07:59:29Z

Hello, you might consider rebuilding the migration from this v14 migration PR as it bring more bugfix that is not present here #1696

github-actions · 2023-09-03T12:24:05Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

guewen and others added 19 commits September 14, 2022 18:17

[ADD] started stock_reserve_sale to reserve lines of quotations

b050d3c

mark unported module as uninstallable

f3eafaf

reactivate module stock_reserve_sale

3caff33

lint

b0c7dbb

fix pep8 W503

0f7f6d0

make stock_reserve_sale owner_aware

1962651

Added the translation template file and Finnish translations to stock…

0dfeb63

…_reserve and stock_reserve_sale.

Add README.rst and remove description from __openerp__.py

7579a6a

Multiple reservations can now be released at once. This fixes issue O…

8fb1b5e

…CA#50.

Add Spanish translation of stock reserve modules

529b541

force recomputation of stock.location hierachy

4fda95a

before running the tests. This fixes the failure experienced when running the test in --init mode rather than --update mode.

OCA Transbot updated translations from Transifex

0286d75

[UPD] prefix versions with 8.0

32597d0

[MIG] Make modules uninstallable

a28f528

[FIX] remove en.po that was erroneously created by transbot

3a08dec

[MIG] Rename manifest files

ea52ce1

remove obsolete .pot files [ci skip]

a2bd3aa

[IMP] stock_reserve_sale: black, isort, prettier

2ee209e

[MIG] stock_reserve_sale: Migration to v13.0

90fd236

flachica mentioned this pull request Sep 15, 2022

Migration to version 15.0 #1278

Open

80 tasks

flachica force-pushed the 15.0-mig-stock_reserve_sale branch from bfc3a0b to 4c5172f Compare September 15, 2022 11:10

victoralmau and others added 4 commits September 28, 2022 15:45

[IMP] stock_reserve_sale: Show Reserve Stock button in sent orders.

c406ae4

TT39113

[ADD] icon.png

dce688b

[IMP] stock_reserve_sale: black, isort

b18ee62

[MIG] stock_reserve_sale 15.0

8500c07

flachica force-pushed the 15.0-mig-stock_reserve_sale branch from 4c5172f to 8500c07 Compare September 28, 2022 13:46

flachica mentioned this pull request Sep 28, 2022

[MIG] stock_reserve 15.0 #1485

Merged

rousseldenis reviewed Oct 11, 2022

View reviewed changes

flachica force-pushed the 15.0-mig-stock_reserve_sale branch 2 times, most recently from a97f4bc to 569a2a7 Compare October 18, 2022 08:46

flachica force-pushed the 15.0-mig-stock_reserve_sale branch 3 times, most recently from b4d4547 to 6d90f69 Compare October 19, 2022 11:12

[TEST] With dependencies.

363b6e4

This commit must be ignored in Odoo Bot merge action

flachica force-pushed the 15.0-mig-stock_reserve_sale branch from 6d90f69 to 363b6e4 Compare October 19, 2022 11:19

max3903 added this to the 15.0 milestone Nov 21, 2022

CasVissers-360ERP suggested changes Nov 25, 2022

View reviewed changes

CasVissers-360ERP reviewed Nov 29, 2022

View reviewed changes

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 9, 2023

rvalyi mentioned this pull request Apr 25, 2023

[14.0] mig stock_reserve_sale #1696

Closed

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 30, 2023

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 3, 2023

github-actions bot closed this Oct 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] stock_reserve_sale 15.0 #1486

[MIG] stock_reserve_sale 15.0 #1486

flachica commented Sep 15, 2022 •

edited

Loading

victoralmau commented Sep 28, 2022

flachica commented Sep 28, 2022

flachica commented Sep 28, 2022

oca-clabot commented Sep 28, 2022

victoralmau commented Sep 28, 2022

rousseldenis commented Oct 11, 2022 •

edited

Loading

flachica commented Oct 11, 2022

rousseldenis Oct 11, 2022

flachica Oct 18, 2022

rousseldenis Oct 18, 2022

flachica Oct 19, 2022

rousseldenis Oct 19, 2022

rousseldenis Oct 19, 2022

rousseldenis Oct 19, 2022

flachica Oct 19, 2022

CasVissers-360ERP left a comment

CasVissers-360ERP Nov 25, 2022

CasVissers-360ERP Nov 25, 2022

CasVissers-360ERP Nov 25, 2022

CasVissers-360ERP Nov 25, 2022

CasVissers-360ERP Nov 25, 2022

CasVissers-360ERP Nov 29, 2022

CasVissers-360ERP Nov 29, 2022

CasVissers-360ERP commented Nov 29, 2022

github-actions bot commented Apr 9, 2023

rvalyi commented Apr 25, 2023

github-actions bot commented Sep 3, 2023

		@@ -0,0 +1 @@
		odoo-addon-stock-reserve @ git+https://github.com/OCA/stock-logistics-warehouse.git@refs/pull/1484/head#subdirectory=setup/stock_reserve



		class SaleStockReserve(models.TransientModel):
		_name = "sale.stock.reserve"

[MIG] stock_reserve_sale 15.0 #1486

[MIG] stock_reserve_sale 15.0 #1486

Conversation

flachica commented Sep 15, 2022 • edited Loading

victoralmau commented Sep 28, 2022

flachica commented Sep 28, 2022

flachica commented Sep 28, 2022

oca-clabot commented Sep 28, 2022

victoralmau commented Sep 28, 2022

rousseldenis commented Oct 11, 2022 • edited Loading

flachica commented Oct 11, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CasVissers-360ERP left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CasVissers-360ERP commented Nov 29, 2022

github-actions bot commented Apr 9, 2023

rvalyi commented Apr 25, 2023

github-actions bot commented Sep 3, 2023

flachica commented Sep 15, 2022 •

edited

Loading

rousseldenis commented Oct 11, 2022 •

edited

Loading