Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] stock_request_mrp: Migration to 15.0 #1469

Merged
merged 6 commits into from
Jan 31, 2023
Merged

[MIG] stock_request_mrp: Migration to 15.0 #1469

merged 6 commits into from
Jan 31, 2023

Conversation

augusto-weiss
Copy link

No description provided.

@rousseldenis
Copy link
Contributor

/ocabot migration stock_request_mrp

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Aug 18, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Aug 18, 2022
Open
80 tasks
rousseldenis
rousseldenis approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rousseldenis
Copy link
Contributor

@augusto-weiss A better PR tittle would help reviewers. Thanks

Like [MIG] stock_request_mrp: Migration to 15.0

@augusto-weiss augusto-weiss changed the title 15.0 mig stock request mrp [MIG] stock_request_mrp: Migration to 15.0 Aug 18, 2022
@augusto-weiss augusto-weiss reopened this Aug 18, 2022
@augusto-weiss augusto-weiss marked this pull request as draft August 18, 2022 18:19
@JoelZilli JoelZilli force-pushed the 15.0-mig-stock_request_mrp branch from 89f31a5 to de0ab0a Compare September 1, 2022 13:39
@rousseldenis
Copy link
Contributor

@augusto-weiss Could you check tests?

@augusto-weiss augusto-weiss marked this pull request as ready for review September 8, 2022 14:12
nicomacr
nicomacr suggested changes Sep 9, 2022
View reviewed changes
Copy link

@nicomacr nicomacr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoelZilli check these points below please

stock_request_mrp/tests/test_stock_request_mrp.py Outdated Show resolved Hide resolved
stock_request_mrp/tests/test_stock_request_mrp.py Outdated Show resolved Hide resolved
@JoelZilli JoelZilli force-pushed the 15.0-mig-stock_request_mrp branch 2 times, most recently from 4424c94 to 21289c5 Compare September 14, 2022 13:15
@nicomacr nicomacr force-pushed the 15.0-mig-stock_request_mrp branch 7 times, most recently from ac1f34f to fcf38d6 Compare September 14, 2022 20:05
@nicomacr nicomacr force-pushed the 15.0-mig-stock_request_mrp branch from fcf38d6 to 719a412 Compare September 14, 2022 20:11
@nicomacr
Copy link

@rousseldenis could you check now this PR?

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 29, 2023
pedrobaeza
pedrobaeza approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-1469-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 31, 2023
@OCA-git-bot
Merge PR #1469 into 15.0
de512f8 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-1469-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-1469-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-1469-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e152943 into OCA:15.0 Jan 31, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c6725c2. Thanks a lot for contributing to OCA. ❤️

@nicomacr nicomacr deleted the 15.0-mig-stock_request_mrp branch January 31, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicomacr nicomacr nicomacr requested changes

@rousseldenis rousseldenis rousseldenis approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
merged 🎉 migration needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
8 participants
@augusto-weiss @rousseldenis @nicomacr @OCA-git-bot @pedrobaeza @HviorForgeFlow @oca-travis @JoelZilli