Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] stock_packaging_calculator #1327

Merged
merged 41 commits into from
Feb 22, 2022

Conversation

ChrisOForgeFlow
Copy link
Contributor

Standard Migration
@ForgeFlow

simahawk and others added 30 commits December 13, 2021 13:14
Customizing the minimal unit was not needed at all.
This way we always assume the precision is the on of the UoM.
Allows to ship more information with each element in the list.
Optionally include contained packaging qty.
Allows to reuse the mapping every time is needed.
Make sure unit is always the last element in the list.
Use _packaging_values_handler ctx key to pass your own handler
for specific on demand overrides.
Copy link
Contributor

@JoanMForgeFlow JoanMForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rousseldenis
Copy link
Contributor

/ocabot migration stock_packaging_calculator

@OCA-git-bot OCA-git-bot mentioned this pull request Dec 14, 2021
80 tasks
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@dreispt
Copy link
Member

dreispt commented Feb 6, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-1327-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 6, 2022
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-1327-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@dreispt
Copy link
Member

dreispt commented Feb 22, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-1327-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4e07ec4 into OCA:15.0 Feb 22, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 679429f. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants