-
-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][MIG] stock_packaging_calculator #1327
[15.0][MIG] stock_packaging_calculator #1327
Conversation
Customizing the minimal unit was not needed at all. This way we always assume the precision is the on of the UoM.
Allows to ship more information with each element in the list.
Optionally include contained packaging qty.
Allows to reuse the mapping every time is needed.
…g calculator return
Make sure unit is always the last element in the list.
Use _packaging_values_handler ctx key to pass your own handler for specific on demand overrides.
Otherwise translations won't be taken into account.
This way no matter who's changing the behavior of the name getter we'll get the right name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/ocabot migration stock_packaging_calculator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-1327-by-dreispt-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
/ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at 679429f. Thanks a lot for contributing to OCA. ❤️ |
Standard Migration
@ForgeFlow