[IMP] reason code location set as a scrap location if set

OCA · Oct 10, 2022 · e86baf5 · e86baf5
1 parent e075a54
commit e86baf5
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/scrap_reason_code/models/stock_scrap.py b/scrap_reason_code/models/stock_scrap.py
@@ -25,21 +25,23 @@ def _onchange_reason_code_id(self):
 
     def write(self, vals):
         if "reason_code_id" in vals:
-            vals.update(
-                {
-                    "scrap_location_id": self.env["scrap.reason.code"]
-                    .browse(vals.get("reason_code_id"))
-                    .location_id
-                }
+            location_id = (
+                self.env["scrap.reason.code"]
+                .browse(vals.get("reason_code_id"))
+                .location_id
             )
+            if location_id:
+                vals.update({"scrap_location_id": location_id})
         return super(StockScrap, self).write(vals)
 
     @api.model
     def create(self, vals):
         if "reason_code_id" in vals:
-            vals["scrap_location_id"] = (
+            location_id = (
                 self.env["scrap.reason.code"]
                 .browse(vals.get("reason_code_id"))
-                .location_id.id
+                .location_id
             )
+            if location_id:
+                vals["scrap_location_id"] = location_id.id
         return super(StockScrap, self).create(vals)