[IMP] stock_pull_list: Rewrite code with help of review

OCA · Oct 9, 2023 · d855feb · d855feb
1 parent 551eba7
commit d855feb
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 11 deletions.
diff --git a/stock_pull_list/__manifest__.py b/stock_pull_list/__manifest__.py
@@ -17,6 +17,7 @@
         "wizards/stock_pull_list_wizard.xml",
         "security/ir.model.access.csv",
         "data/stock_pull_list_sequence_data.xml",
+        "data/data.xml",
         "views/stock_picking_views.xml",
     ],
     "installable": True,

diff --git a/stock_pull_list/data/data.xml b/stock_pull_list/data/data.xml
@@ -0,0 +1,11 @@
+<odoo>
+    <record model="ir.actions.server" id="stock_generate_pull_list">
+        <field name="name">Generate Pull List</field>
+        <field name="model_id" ref="stock.model_stock_picking" />
+        <field name="binding_model_id" ref="stock.model_stock_picking" />
+        <field name="state">code</field>
+        <field name="code">
+            action = records.action_create_pull_list()
+        </field>
+    </record>
+</odoo>
diff --git a/stock_pull_list/models/stock_picking.py b/stock_pull_list/models/stock_picking.py
@@ -7,7 +7,7 @@ class StockPicking(models.Model):
 
     def action_create_pull_list(self):
 
-        source_location = self[0].location_id
+        source_location = fields.first(self).location_id
         for record in self:
             if source_location != record.location_id:
                 raise UserError(_("Choose transfers with same source location"))

diff --git a/stock_pull_list/views/stock_picking_views.xml b/stock_pull_list/views/stock_picking_views.xml
@@ -9,14 +9,4 @@
             </xpath>
         </field>
     </record>
-
-    <record model="ir.actions.server" id="stock_generate_pull_list">
-        <field name="name">Generate Pull List</field>
-        <field name="model_id" ref="stock.model_stock_picking" />
-        <field name="binding_model_id" ref="stock.model_stock_picking" />
-        <field name="state">code</field>
-        <field name="code">
-            action = records.action_create_pull_list()
-        </field>
-    </record>
 </odoo>