Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][ADD] stock_picking_auto_print: New module #347

Open
wants to merge 1 commit into
base: 15.0
Choose a base branch
from

Conversation

sergio-teruel
Copy link
Contributor

@sergio-teruel sergio-teruel commented Oct 8, 2024

cc @Tecnativa TT51076

ping @chienandalu

@sergio-teruel sergio-teruel marked this pull request as draft October 8, 2024 20:57
@@ -0,0 +1 @@
This module allows to auto print delivery slip after validation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This module allows to auto print delivery slip after validation
This is a backport of the Odoo 17 functionality that allows to auto print delivery slip after validation

class StockPickingType(models.Model):
_inherit = "stock.picking.type"

auto_print_delivery_slip = fields.Boolean(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we add the auto_print_return_slip as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In v15 does not exist the returned report

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, ok 👍

def button_validate(self):
res = super().button_validate()

pickings_to_print = self.filtered(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"name": "Stock Picking Auto Print",
"summary": "Print picking delivery slip automatically after validation",
"version": "15.0.1.0.0",
"author": "Tecnativa, Odoo Community Association (OCA)",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"author": "Tecnativa, Odoo Community Association (OCA)",
"author": "Odoo S.A., Tecnativa, Odoo Community Association (OCA)",

@@ -0,0 +1,17 @@
# Copyright 2024 Tecnativa - Sergio Teruel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Copyright 2024 Tecnativa - Sergio Teruel
# Copyright 2024 Tecnativa - Sergio Teruel
# Copyright 2024 Odoo S.A.

<group name="auto_print">
<group string="Print on Validation">
<field name="auto_print_delivery_slip" string="Delivery Slip" />
<field name="auto_print_return_slip" string="Return Slip" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't exist

Suggested change
<field name="auto_print_return_slip" string="Return Slip" />

@sergio-teruel sergio-teruel force-pushed the 15.0-ADD-stock_picking_auto_print branch 2 times, most recently from 000bbe6 to 8b0f796 Compare October 9, 2024 10:08
@sergio-teruel
Copy link
Contributor Author

Changes done!

@sergio-teruel sergio-teruel force-pushed the 15.0-ADD-stock_picking_auto_print branch from 8b0f796 to b6f31ac Compare October 10, 2024 08:00
@sergio-teruel sergio-teruel marked this pull request as ready for review October 10, 2024 08:00
@sergio-teruel sergio-teruel force-pushed the 15.0-ADD-stock_picking_auto_print branch 3 times, most recently from c5615f5 to 4bd145d Compare October 11, 2024 08:55
@sergio-teruel
Copy link
Contributor Author

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests failing now...

@sergio-teruel sergio-teruel force-pushed the 15.0-ADD-stock_picking_auto_print branch from 4bd145d to c2dd069 Compare October 11, 2024 18:34
@sergio-teruel
Copy link
Contributor Author

@chienandalu Fixed!!

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working right 👍

@rousseldenis rousseldenis added this to the 15.0 milestone Oct 14, 2024
<?xml version="1.0" encoding="utf-8" ?>
<odoo>

<record model="ir.ui.view" id="view_partner_valued_picking">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<record model="ir.ui.view" id="view_partner_valued_picking">
<record model="ir.ui.view" id="view_picking_type_form">

<field name="arch" type="xml">
<sheet>
<group name="auto_print">
<group string="Print on Validation">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<group string="Print on Validation">
<group name="print_on_validation" string="Print on Validation">

@sergio-teruel sergio-teruel force-pushed the 15.0-ADD-stock_picking_auto_print branch from c2dd069 to 7046820 Compare October 18, 2024 09:24
@sergio-teruel
Copy link
Contributor Author

Changes done!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants