[16.0][MIG] stock_orderpoint_mto_as_mts #14
Conversation
tuantrantg
force-pushed
the
16.0-mig-stock_orderpoint_mto_as_mts
branch
3 times, most recently
from
c3e741c to
fba9cc7
Compare
tuantrantg
force-pushed
the
16.0-mig-stock_orderpoint_mto_as_mts
branch
2 times, most recently
from
26327d1 to
f405e88
Compare
tuantrantg
force-pushed
the
16.0-mig-stock_orderpoint_mto_as_mts
branch
from
f405e88 to
65bb160
Compare
| def _get_warehouse_missing_orderpoint_for_mto(self): | ||
| res = {} | ||
| wh_obj = self.env["stock.warehouse"] | ||
| for product in self: |
There was a problem hiding this comment.
| for product in self: | |
| for product in self: | |
| if not product.purchase_ok: | |
| continue |
There's no point to create a orderpoints for products that can not be purchased.
That is in conflict with the validation done in purchase_reorder_control
Unpurchaseable Products cannot be reordered
https://github.com/OCA/purchase-workflow/blob/e113f0a3a046ad832f2e324df50301c276932fa4/purchase_reorder_control/models/stock_warehouse_orderpoint.py#L21
tuantrantg
force-pushed
the
16.0-mig-stock_orderpoint_mto_as_mts
branch
from
65bb160 to
cbf3127
Compare
For user without proper rights the confirmation of a sale.order can lead to an access error on the orderpoint creation. The sudo fixes that.
tuantrantg
force-pushed
the
16.0-mig-stock_orderpoint_mto_as_mts
branch
from
cbf3127 to
4c6119b
Compare
tuantrantg
force-pushed
the
16.0-mig-stock_orderpoint_mto_as_mts
branch
from
4c6119b to
fc51a5d
Compare
| self.ensure_one() | ||
| res = False | ||
| wh_obj = self.env["stock.warehouse"] | ||
| for product in self: |
There was a problem hiding this comment.
drop for loop as you have ensure_one()
| that have no orderpoint yet. | ||
| """ | ||
| for product in self: | ||
| wh = product._get_warehouse_missing_orderpoint_for_mto() |
There was a problem hiding this comment.
I don't see where you check it is a mto product
mto_products = self._filter_mto_products()
| return products | ||
|
|
||
| def write(self, vals): | ||
| # Archive orderpoints when MTO route is removed |
|
/ocabot migration stock_orderpoint_mto_as_mts |
|
There's no issue in this repo with the title 'Migration to version 16.0' and the milestone 16.0, so not possible to add the comment. |
| products.sudo()._ensure_default_orderpoint_for_mto() | ||
| return products | ||
|
|
||
| def write(self, vals): |
There was a problem hiding this comment.
You need to look invals for is_mto or company_id. Those are on product.template, so you need to move the hook to write on the right model
There was a problem hiding this comment.
I don't really understand the method
res = super().write(vals)
if vals.get("is_mto"):
# when is_mto is set
self.sudo()._ensure_default_orderpoint_for_mto()
elif not vals.get("is_mto", True):
# when is_mto is removed
self.sudo()._archive_orderpoints_on_mto_removal()
elif "company_id" in vals:
# when company is changed
self.sudo()._archive_orderpoints_on_mto_removal()
self.sudo()._ensure_default_orderpoint_for_mto()
return res
|
|
||
| _inherit = "stock.warehouse" | ||
|
|
||
| mto_as_mts = fields.Boolean(default=False) |
There was a problem hiding this comment.
When you flag this, you could archive from the MTO route the rule for this warehouse
Depends on:
Notes:
is_mtoon product (depend on product-attribute/product_route_mto)is_mtoon route instead of xmlid (provided by stock-logistics-warehouse/stock_route_mto - already pulled by product_route_mto)product.product:product.templateand refactored itis_from_mto_routeonstock.move. That should not be in this module, not related to orderpoint