Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] barcodes_generator_abstract: Migration to 14.0 #313

Closed

Conversation

chafique-delli
Copy link

No description provided.

legalsylvain and others added 30 commits December 11, 2020 15:23
* Rename manifest
* Change openerp references to odoo
* Bump version
* Alphabetize imports
* pyBarcode is no longer maintained, switch to viivakoodi fork (https://bitbucket.org/whitie/python-barcode/issues/16/pypi-08-release-request#comment-33978213)
)

Add an option to allow for automatic generation of barcode when a record of mixin model is created
* [FIX] barcodes_generator_abstract: Caching issue
* Make cache method return ids & move the recordset method out of cache to fix OCA#93
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-barcode-11.0/stock-logistics-barcode-11.0-barcodes_generator_abstract
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-11-0/stock-logistics-barcode-11-0-barcodes_generator_abstract/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-barcode-12.0/stock-logistics-barcode-12.0-product_multi_ean
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-12-0/stock-logistics-barcode-12-0-product_multi_ean/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-barcode-12.0/stock-logistics-barcode-12.0-barcodes_generator_abstract
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-12-0/stock-logistics-barcode-12-0-barcodes_generator_abstract/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-barcode-12.0/stock-logistics-barcode-12.0-barcodes_generator_abstract
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-12-0/stock-logistics-barcode-12-0-barcodes_generator_abstract/
Currently translated at 29.6% (8 of 27 strings)

Translation: stock-logistics-barcode-12.0/stock-logistics-barcode-12.0-barcodes_generator_abstract
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-12-0/stock-logistics-barcode-12-0-barcodes_generator_abstract/de/
Currently translated at 14.8% (4 of 27 strings)

Translation: stock-logistics-barcode-12.0/stock-logistics-barcode-12.0-barcodes_generator_abstract
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-12-0/stock-logistics-barcode-12-0-barcodes_generator_abstract/sl/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-barcode-12.0/stock-logistics-barcode-12.0-barcodes_generator_abstract
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-12-0/stock-logistics-barcode-12-0-barcodes_generator_abstract/
oca-transbot and others added 4 commits December 11, 2020 15:23
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-barcode-12.0/stock-logistics-barcode-12.0-barcodes_generator_abstract
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-12-0/stock-logistics-barcode-12-0-barcodes_generator_abstract/
Currently translated at 46.4% (13 of 28 strings)

Translation: stock-logistics-barcode-12.0/stock-logistics-barcode-12.0-barcodes_generator_abstract
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-12-0/stock-logistics-barcode-12-0-barcodes_generator_abstract/it/
Improve form view of barcode rules
Improve README
Auto-add admin to the group
@@ -32,8 +30,6 @@ class BarcodeGenerateMixin(models.AbstractModel):

generate_type = fields.Selection(
string="Generate Type",
selection=_GENERATE_TYPE,
readonly=True,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand that move. could you explain why you remove that two lines ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On recent Odoo versions, releated fields are readonly by default, so no need to write it explicitely. And selection= is not needed on a related field, it's automatic.

@chafique-delli chafique-delli mentioned this pull request Jan 4, 2021
15 tasks
Copy link

@hparfr hparfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests written in v13 are missing.

@alexis-via
Copy link
Contributor

I won't contribute on this PR any more because I now use my module product_print_zpl_barcode to generate product barcodes (cf https://github.com/akretion/odoo-usability/blob/14.0/product_print_zpl_barcode/models/product.py#L49). Maybe @chafique-delli will continue to work on this PR.

@Zar21
Copy link
Contributor

Zar21 commented May 18, 2021

I test your module and the barcode dependency is wrong since this module is using the get_barcode_class function and this function depends on the python library python-barcode, so you should change this.
If you couldn't change this, I can do it.

@Zar21
Copy link
Contributor

Zar21 commented May 19, 2021

Superseeded by #340

@hugho-ad
Copy link
Contributor

@pedrobaeza

could you close this pls

superbased by #340

@pedrobaeza pedrobaeza closed this Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.