Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency in setup.py from viivakoodi to python-barcode #194

Closed
wants to merge 1 commit into from
Closed

Update dependency in setup.py from viivakoodi to python-barcode #194

wants to merge 1 commit into from

Conversation

yucer
Copy link

@yucer yucer commented Jul 30, 2019

The python-barcode project is active again and it seems to enhace
the support for python3. It also uses Pillow instead of PIL.

Ref: #193

The `python-barcode` project is active again and it seems to enhace
the support for python3. It also uses `Pillow` instead of `PIL`.

Ref: #93
@pedrobaeza
Copy link
Member

Changing this dependency in a stable version is not a good idea. You can provide code for using the other one if detected, but not change the manifest external dependencies.

Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yucer,

You should change also here.
https://github.com/OCA/stock-logistics-barcode/blob/11.0/requirements.txt#L2
Could you rgrep your repo to be sure all reference to viivakoodi has been changed ?

@lasley, please comment this change. regards.

Changing this dependency in a stable version is not a good idea. You can provide code for using the other one if detected, but not change the manifest external dependencies.

Thanks @pedrobaeza , 👍 Better to do it for V13 serie. (coming soon !)

for that branch, you can add a text in the ROADMAP.rst file of the module(s) to mention that the change should be done when migrating.

king regards.

@yucer
Copy link
Author

yucer commented Jul 30, 2019

Hi @legalsylvain, @lasley , @pedrobaeza

+1 Better to do it for V13 serie. (coming soon !)

Actually, I don't need it for v10.

I did just saw the dependency and try to figure it out what it was. Later I did discover that there was another project more active and we did talk about it in Ref #193.

Feel free to close the PR and submit new ones for the latest version, if the decision is to change.

Kind regards.

@legalsylvain
Copy link
Contributor

All right. We'll see when migrating this module. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants