[16.0][MIG] base_export_manager: Migration to version 16.0 #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chienandalu
suggested changes
Aug 4, 2023
|
Did you see #563 ? |
|
This superseeds a more complete PR. Anyway, it has a better approach to the invalidate_recordset approach is maybe more clear and self explanatory |
|
Then it's fair to credit the author of the first PR ever. What about rebasing this one over the other? |
|
Ok, it shouldn't be that hard to cherry-pick and resolve a pair of conflicts. |
I see the situation, what I do then? Rebase this PR with the other one? Or I cherry-pick the migration commit of the other PR, resolve the conflicts and, eventually, squash this PR's migration commit maintaining the authorship? |
|
Save your current work, cherry pick the migration commit of the other PR, and put your relevant changes on it, doing another commit. |
|
Well, cherry pick both migration commits indeed, as you've got two contributors to keep credit to |
stefan-tecnativa
force-pushed
the
16.0-mig-base_export_manager
branch
from
fb5050d
to
3f377f4
Compare
|
@chienandalu it's the history okay now? I will now review your comments |
* Improve UX for base_export_manager. - Improve user instructions in README. - Require some required fields. - Allow to select models from a list. - Allow to select up to 3 fields from dynamic lists. - Improve translations. - More tests. - Translate column labels. Some methods have been renamed, so version tag is raised to 8.0.2.0.0. * Make inverse method be called at view time. * Hardcode constraints in the `create` method instead of using normal ones. Depending on the context where the record is created, it gets `resource` or `model_id`. The problem is that Odoo checks constrains before inverses, so constrains would fail always. Test added to ensure future versions contemplate all use cases. * Allow to reorder fields.
* Upgrade base_export_manager to v9 * Rename JS to base_export_manager
* Change osv_memory to transient for model_id domain
* Improve UX for base_export_manager. - Improve user instructions in README. - Require some required fields. - Allow to select models from a list. - Allow to select up to 3 fields from dynamic lists. - Improve translations. - More tests. - Translate column labels. Some methods have been renamed, so version tag is raised to 8.0.2.0.0. * Hardcode constraints in the `create` method instead of using normal ones. Depending on the context where the record is created, it gets `resource` or `model_id`. The problem is that Odoo checks constrains before inverses, so constrains would fail always. Test added to ensure future versions contemplate all use cases. * Allow to reorder fields.
…9 * Rename JS to base_export_manager
[FIX][base_export_manager] Fix "Expected singleton" bug.
If you had a field that got translated in more than 1 addon, you'd possibly getto this error:
File "/opt/odoo/0079_ahk_openerp/oca/base_export_manager/models/ir_exports_line.py", line 105, in _compute_label
field.name)),
File "/opt/odoo/common/openerp/v8/openerp/fields.py", line 825, in __get__
record.ensure_one()
File "/opt/odoo/common/openerp/v8/openerp/models.py", line 5355, in ensure_one
raise except_orm("ValueError", "Expected singleton: %s" % self)
except_orm: ('ValueError', 'Expected singleton: ir.translation(4899, 703976)')
With this patch, now we let Odoo return the translated string by using its
standard method to do so, so we have to care for less.
* Move installation outside a data file.
This makes the whole installation to be able to roll back if something goes
wrong, instead of entering an error loop.
* Include envorionment in its manager.
* Add 4th field
* Move to api.multi, refactoring some stuff.
- Add some comments in complex parts.
- Rename `onchange_name` to `_onchange_name` (guidelines).
- Make `_compute_name`'s try block shorter and easier to understand.
* Allow R/W of name directly in model.
* Update tests to cover new behaviors.
- Remove all possible translation commits - Aesthetical changes - Bump version - Some new standards, such as split readme Basically, nothing.
Currently translated at 80.0% (20 of 25 strings) Translation: server-ux-11.0/server-ux-11.0-base_export_manager Translate-URL: https://translation.odoo-community.org/projects/server-ux-11-0/server-ux-11-0-base_export_manager/da/
Currently translated at 100.0% (31 of 31 strings) Translation: server-ux-12.0/server-ux-12.0-base_export_manager Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_export_manager/pt/
Currently translated at 100.0% (31 of 31 strings) Translation: server-ux-14.0/server-ux-14.0-base_export_manager Translate-URL: https://translation.odoo-community.org/projects/server-ux-14-0/server-ux-14-0-base_export_manager/es/
If not, we are not assigning the label value for the record and we get a missing cache value error.
WARNING odoo.fields: Redundant default on ir.exports.line.model1_id
stefan-tecnativa
force-pushed
the
16.0-mig-base_export_manager
branch
from
3f377f4
to
9d46ab7
Compare
chienandalu
reviewed
Aug 4, 2023
| @@ -29,52 +29,48 @@ | |||
| <field name="model">ir.exports</field> | |||
| <field name="arch" type="xml"> | |||
| <form string="Export Profile"> | |||
| <sheet> | |||
There was a problem hiding this comment.
You're dismissing the changes of the previous commit here.
There was a problem hiding this comment.
Thanks for the advice, now it should be correct
stefan-tecnativa
force-pushed
the
16.0-mig-base_export_manager
branch
from
9d46ab7
to
f1b30ac
Compare
stefan-tecnativa
force-pushed
the
16.0-mig-base_export_manager
branch
from
f1b30ac
to
1eb0ee3
Compare
kikopeiro
approved these changes
Aug 8, 2023
|
/ocabot migration base_export_manager |
|
Please include #704 |
Steps to reproduce: - Create an export profile in any model. - Login with a user without setting permissions. - Go to export popup on that model. - Try to select the saved export profile. You'll get an access error. Using sudo for computed/related stuff linked to ir.model, we avoid the problem. TT44721
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 856f9fa. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT43220
This Pr superseeds: #649
@CarlosRoca13 @chienandalu please review!