[15.0][MIG] sequence_check_digit: Migration to 15.0 #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [ADD] Sequence check Digit * Change of License to LGPL * Code review * Reviews
Currently translated at 100,0% (13 of 13 strings) Translation: server-ux-11.0/server-ux-11.0-sequence_check_digit Translate-URL: https://translation.odoo-community.org/projects/server-ux-11-0/server-ux-11-0-sequence_check_digit/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-12.0/server-ux-12.0-sequence_check_digit Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-sequence_check_digit/
Fix external dependency from `stdnum` to `python-stdnum`
kaynnan
force-pushed
the
15.0-mig-sequence_check_digit
branch
from
e3a30df
to
073c4f1
Compare
|
@augustodinizl @aug1804 Can you do the functional review please? |
etobella
reviewed
Jul 22, 2023
| @@ -37,17 +37,17 @@ def check_check_digit_formula(self): | |||
| try: | |||
| self.get_next_char(0) | |||
| except Exception: | |||
| raise ValidationError(_("Format is not accepted")) | |||
| raise ValidationError(_("Format is not accepted")) from None | |||
There was a problem hiding this comment.
Why did you add the from None?
There was a problem hiding this comment.
Due to the suggestion made by the pre-commit
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at ffd05c7. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @marcelsavegnago
#390