Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] base_duplicate_security_group: Migration to 15.0 #608

Merged
merged 3 commits into from
Mar 6, 2023
Merged

[15.0][MIG] base_duplicate_security_group: Migration to 15.0 #608

merged 3 commits into from
Mar 6, 2023

Conversation

chienandalu
Copy link
Member

@chienandalu chienandalu commented Mar 1, 2023 •
edited
Loading

cc @Tecnativa TT37272

please review @CarlosRoca13 @victoralmau

@chienandalu chienandalu force-pushed the 15.0-mig-base_duplicate_security_group branch 3 times, most recently from eff9bea to 5fc40f7 Compare March 2, 2023 10:45
@chienandalu chienandalu force-pushed the 15.0-mig-base_duplicate_security_group branch from 5fc40f7 to 04637d5 Compare March 2, 2023 10:56
@simahawk simahawk mentioned this pull request Mar 2, 2023
Closed
victoralmau
victoralmau approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review OK

CarlosRoca13
CarlosRoca13 reviewed Mar 2, 2023
View reviewed changes
Copy link
Contributor

@CarlosRoca13 CarlosRoca13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄 thanks

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot migration base_duplicate_security_group
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Mar 6, 2023
@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-608-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Mar 6, 2023
Closed
34 tasks
@OCA-git-bot OCA-git-bot merged commit 47ec61b into OCA:15.0 Mar 6, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d3c7040. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victoralmau victoralmau victoralmau approved these changes

@CarlosRoca13 CarlosRoca13 CarlosRoca13 approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
5 participants
@chienandalu @OCA-git-bot @pedrobaeza @victoralmau @CarlosRoca13