Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] 15.0 mass_editing #409

Merged
merged 70 commits into from
Dec 28, 2021
Merged

[MIG] 15.0 mass_editing #409

merged 70 commits into from
Dec 28, 2021

Conversation

Tatider
Copy link

@Tatider Tatider commented Nov 22, 2021

No description provided.

@Tatider Tatider mentioned this pull request Nov 22, 2021
Closed
34 tasks
@Tatider Tatider force-pushed the 15.0-mig-mass_editing branch 8 times, most recently from e89993c to 6951b64 Compare November 23, 2021 17:20
@LoisRForgeFlow
Copy link
Contributor

/ocabot migration mass_editing

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Dec 13, 2021
JasminSForgeFlow
JasminSForgeFlow approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@JasminSForgeFlow JasminSForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@legalsylvain
Copy link
Contributor

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Sorry @legalsylvain you are not allowed to rebase.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@legalsylvain
Copy link
Contributor

Hi @Tatider : could you rebase, I'd like to test on runboat, but the buid is not available.

thanks

SerpentCS and others added 11 commits December 17, 2021 17:16
@SerpentCS
[ADD] Added mass_editing module compatible to version 7.0
948e8dc
@AnuKPatel
[IMP] mass_editing: Corrections based on the merge comments
7df1b66
[ENH] Transformed mass.object's model_list char field into a proper m…
48e0376 
…2m field.
@dsabrinarg
[IMP] Added one2many handling
3f39e1b
@yajo
Add spanish translation and translation template.
7210eca
[IMP] In 7.0 version of OpenERP it is unnecessary put the type of vie…
8cd5cf9 
…w when we define it, is why that I remove the tag type in the view to avoid that server shows us a warning
Launchpad automatic translations update.
f09a93e
@legalsylvain
[REF] 'mass_editing': flake8.
989cd5f
@sbidoul
move all modules to __unported__ on master branch and set installable…
525c7dc 
…=False
@oihane
[ADD] Migrated <mass_editing> for Odoo
6237ce0
@bwrsandman
Tighten type check in domain
8169711 
Fixes OCA#15
Check that `domain[2]` is `str` because in some cases it's an `int` and `list`
operations don't work on `int`s.
OCA-git-bot and others added 8 commits December 17, 2021 17:16
@OCA-git-bot
mass_editing 14.0.1.0.1
226258e
@anasuarez1
Translated using Weblate (Spanish)
f380d54 
Currently translated at 97.1% (34 of 35 strings)

Translation: server-ux-14.0/server-ux-14.0-mass_editing
Translate-URL: https://translation.odoo-community.org/projects/server-ux-14-0/server-ux-14-0-mass_editing/es/
@Yvesldff
Added translation using Weblate (French (France))
61c6f24
@Yvesldff
Translated using Weblate (French (France))
a8ecb97 
Currently translated at 64.2% (27 of 42 strings)

Translation: server-ux-14.0/server-ux-14.0-mass_editing
Translate-URL: https://translation.odoo-community.org/projects/server-ux-14-0/server-ux-14-0-mass_editing/fr_FR/
@bosd
Translated using Weblate (Dutch)
c5adcb5 
Currently translated at 54.2% (19 of 35 strings)

Translation: server-ux-14.0/server-ux-14.0-mass_editing
Translate-URL: https://translation.odoo-community.org/projects/server-ux-14-0/server-ux-14-0-mass_editing/nl/
@Yvesldff
Translated using Weblate (French)
ae9cc20 
Currently translated at 100.0% (35 of 35 strings)

Translation: server-ux-14.0/server-ux-14.0-mass_editing
Translate-URL: https://translation.odoo-community.org/projects/server-ux-14-0/server-ux-14-0-mass_editing/fr/
@francesco-ooops
Translated using Weblate (Italian)
1d08c78 
Currently translated at 100.0% (35 of 35 strings)

Translation: server-ux-14.0/server-ux-14.0-mass_editing
Translate-URL: https://translation.odoo-community.org/projects/server-ux-14-0/server-ux-14-0-mass_editing/it/
[IMP] mass_editing: black, isort, prettier
fff4e32
@Tatider
Copy link
Author

Tatider commented Dec 17, 2021

@legalsylvain rebased

HaraldPanten
HaraldPanten suggested changes Dec 18, 2021
View reviewed changes
Copy link

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's functionally working fine, but you have to correct the commit message. You wrote that this is the migration for V14, but you're migrating the module to V15.

See my screenshot:

Captura de pantalla 2021-12-18 a las 10 48 18

@Tatider
Copy link
Author

Tatider commented Dec 20, 2021

@HaraldPanten Oh. my bad. The commit message is fixed now.

@HaraldPanten
Copy link

I still see Migration to 14.0. Didn't you force the push?

@Tatider
Copy link
Author

Tatider commented Dec 21, 2021

@HaraldPanten now should be better (I hadn't noticed it asked for key phase)

HaraldPanten
HaraldPanten approved these changes Dec 21, 2021
View reviewed changes
Copy link

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@jcdrubay
Copy link

Looking forward to the merge :)

@simahawk
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-409-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2377877 into OCA:15.0 Dec 28, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3aef0eb. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreispt dreispt dreispt approved these changes

@HaraldPanten HaraldPanten HaraldPanten approved these changes

@JasminSForgeFlow JasminSForgeFlow JasminSForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.