Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0][base_tier_validation] add 'can_review' #20

Merged

Conversation

JordiBForgeFlow
Copy link
Member

Add 'can_review' to tier.validation so that the buttons approve and reject can be hidden according to this computed field.

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

and reject can be hidden according to this computed field.
@JordiBForgeFlow JordiBForgeFlow force-pushed the 11.0-base_tier_validation-can_review branch from 1426db2 to cbb9dd3 Compare September 17, 2018 14:37
Copy link

@acsonefho acsonefho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (about code)

@JordiBForgeFlow JordiBForgeFlow merged commit 39871e0 into OCA:11.0 Oct 8, 2018
@LoisRForgeFlow LoisRForgeFlow deleted the 11.0-base_tier_validation-can_review branch October 8, 2018 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants