[10.0][MIG] auth_admin_passkey #776

Fenkiou · 2017-03-13T23:04:02Z

This is a port of auth_admin_passkey from 8.0.

I changed the way the verification is done, but it works same as before.

eugen-don · 2017-03-15T13:39:33Z

@Fenkiou thanks as well, i was trying to get this module working on V.10 and discovered your pull.

You forgot to change openerp to odoo in auth_admin_passkey/view/res_config_view.xml

Fenkiou · 2017-03-15T18:23:20Z

@eugen-don Good spot, thanks

eugen-don · 2017-03-25T19:07:29Z

auth_admin_passkey/view/res_config_view.xml

                    <group>
                        <label for="id" string="Passkey"/>
                        <div>
                            <div>
-                                <field name="auth_admin_passkey_send_to_admin" class="oe_inline"/>
+                                <field name="" class="oe_inline"/>


replace this line with: <field name="auth_admin_passkey_send_to_admin" class="oe_inline"/>

Hum, I don't understand why this change is in the PR as not in my own branch..

EDIT: Nevermind, this is present in my branch but I still don't understand why I removed this..

eugen-don

you need to call get_default_auth_admin_passkey_send_to_admin method with one more argument fields

edit: applies to the other methods as well

Fenkiou · 2017-03-28T17:26:31Z

@eugen-don You're right about the missing argument, I'll fix that.

eugen-don · 2017-03-29T11:17:25Z

@Fenkiou I also was trying to get it to work with the adittional fields argument. But if i add fields as argument, like some other modules inheriting res.config do i get this error:

Traceback (most recent call last):
File "/opt/odoo/10/srv/odoo/http.py", line 638, in _handle_exception
return super(JsonRequest, self)._handle_exception(exception)
File "/opt/odoo/10/srv/odoo/http.py", line 675, in dispatch
result = self._call_function(**self.params)
File "/opt/odoo/10/srv/odoo/http.py", line 331, in _call_function
return checked_call(self.db, *args, **kwargs)
File "/opt/odoo/10/srv/odoo/service/model.py", line 119, in wrapper
return f(dbname, *args, **kwargs)
File "/opt/odoo/10/srv/odoo/http.py", line 324, in checked_call
result = self.endpoint(*a, **kw)
File "/opt/odoo/10/srv/odoo/http.py", line 933, in call
return self.method(*args, **kw)
File "/opt/odoo/10/srv/odoo/http.py", line 504, in response_wrap
response = f(*args, **kw)
File "/opt/odoo/10/srv/addons/web/controllers/main.py", line 878, in call_kw
return self._call_kw(model, method, args, kwargs)
File "/opt/odoo/10/srv/addons/web/controllers/main.py", line 870, in _call_kw
return call_kw(request.env[model], method, args, kwargs)
File "/opt/odoo/10/srv/odoo/api.py", line 679, in call_kw
return call_kw_model(method, model, args, kwargs)
File "/opt/odoo/10/srv/odoo/api.py", line 664, in call_kw_model
result = method(recs, *args, **kwargs)
File "/opt/odoo/10/srv/odoo/addons/base/res/res_config.py", line 508, in default_get
res.update(getattr(self, method)(fields))
File "/opt/odoo/10/custom/testing/auth_admin_passkey/model/res_config.py", line 45, in get_default_auth_admin_passkey_send_to_admin
'auth_admin_passkey.send_to_admin', 'True')),
TypeError: 'module' object is not callable

Any idea?

JonathanNEMRY · 2017-03-29T13:02:40Z

Hello I think is should be more easier to migrate this module from 9.0 to 10.0 as api didn't change so much from there instead of 8.0 to 10.0
Moreover a work has been done by @rvalyi here #522 and should be merged soon (I hope...)

eugen-don · 2017-03-29T13:06:39Z

Thanks for the info @JonathanNEMRY

@Fenkiou what do you think? Any way to join efforts?

Fenkiou · 2017-03-29T17:15:27Z

@eugen-don, @JonathanNEMRY I saw this PR but as not merged didn't start from it.

But it's still overriding authenticate method as in 8.0 version and IMHO is not the right way to do it as odoo provide check_credentials method to use custom auth mechanism. I should have told that in PR.

@eugen-don, about your error, I couldn't reproduce it. Are you using my code or your own ? If it's your own, you should post it here :)

eugen-don · 2017-03-29T18:11:23Z

@Fenkiou
was my own code, since your method was called with one arg short...
I gues you corrected it? If so ill test your code tomorrow

eugen-don · 2017-03-30T15:38:43Z

@Fenkiou looks like theres still some work to do.
Its your code i used this time...

Any idea?

Traceback (most recent call last):
File "/opt/odoo/10/srv/odoo/http.py", line 638, in _handle_exception
return super(JsonRequest, self)._handle_exception(exception)
File "/opt/odoo/10/srv/odoo/http.py", line 675, in dispatch
result = self._call_function(**self.params)
File "/opt/odoo/10/srv/odoo/http.py", line 331, in _call_function
return checked_call(self.db, *args, **kwargs)
File "/opt/odoo/10/srv/odoo/service/model.py", line 119, in wrapper
return f(dbname, *args, **kwargs)
File "/opt/odoo/10/srv/odoo/http.py", line 324, in checked_call
result = self.endpoint(*a, **kw)
File "/opt/odoo/10/srv/odoo/http.py", line 933, in call
return self.method(*args, **kw)
File "/opt/odoo/10/srv/odoo/http.py", line 504, in response_wrap
response = f(*args, **kw)
File "/opt/odoo/10/srv/addons/web/controllers/main.py", line 878, in call_kw
return self._call_kw(model, method, args, kwargs)
File "/opt/odoo/10/srv/addons/web/controllers/main.py", line 870, in _call_kw
return call_kw(request.env[model], method, args, kwargs)
File "/opt/odoo/10/srv/odoo/api.py", line 679, in call_kw
return call_kw_model(method, model, args, kwargs)
File "/opt/odoo/10/srv/odoo/api.py", line 664, in call_kw_model
result = method(recs, *args, **kwargs)
File "/opt/odoo/10/srv/odoo/addons/base/res/res_config.py", line 508, in default_get
res.update(getattr(self, method)(fields))
File "/opt/odoo/10/custom/testing/auth_admin_passkey/model/res_config.py", line 35, in get_default_auth_admin_passkey_send_to_admin
'auth_admin_passkey.send_to_admin', 'True')),
TypeError: 'module' object is not callable

code res_config:
`from odoo import api, fields, models
from odoo.tools import safe_eval

class BaseConfigSettings(models.TransientModel):
_inherit = 'base.config.settings'

@api.model
def get_default_auth_admin_passkey_send_to_admin(self, _):
    icp = self.env['ir.config_parameter']
    return {
        'auth_admin_passkey_send_to_admin': safe_eval(icp.get_param(
            'auth_admin_passkey.send_to_admin', 'True')),
    }

@api.model
def get_default_auth_admin_passkey_send_to_user(self, _):
    icp = self.env['ir.config_parameter']
    return {
        'auth_admin_passkey_send_to_user': safe_eval(icp.get_param(
            'auth_admin_passkey.send_to_user', 'True')),
    }

auth_admin_passkey_send_to_admin = fields.Boolean(
    'Send email to admin user.',
    help=('When the administrator use his password to login in '
          'with a different account, OpenERP will send an email '
          'to the admin user.'),
)
auth_admin_passkey_send_to_user = fields.Boolean(
    string='Send email to user.',
    help=('When the administrator use his password to login in '
          'with a different account, OpenERP will send an email '
          'to the account user.'),
)

@api.multi
def set_auth_admin_passkey_send_to_admin(self):
    self.ensure_one()

    icp = self.env['ir.config_parameter']
    icp.set_param(
        'auth_admin_passkey.send_to_admin',
        repr(self.auth_admin_passkey_send_to_admin))

@api.multi
def set_auth_admin_passkey_send_to_user(self):
    self.ensure_one()

    icp = self.env['ir.config_parameter']
    icp.set_param(
        'auth_admin_passkey.send_to_user',
        repr(self.auth_admin_passkey_send_to_user))

`

Fenkiou · 2017-03-30T17:48:10Z

@eugen-don Hum.. I still cannot reproduce your issue..

When the error is raised ? When you install the module ? When you go to General Settings ? Did you try to uninstall and reinstall the module ? Is your odoo up to date ? :)

eugen-don · 2017-03-31T01:04:23Z

@Fenkiou
Seems like OCA runbot does not reproduce the issue?

But i just did a fresh pull from odoo repo and still get the error...

eugen-don · 2017-03-31T07:31:18Z

@Fenkiou
I just added some commits in your repo... they dont solve the above error... only some small fixes and readme update

Fenkiou · 2017-04-01T11:20:16Z

@legalsylvain, @pedrobaeza Hi guys, sorry to ping you but we have an issue with this addon with @eugen-don and don't understand why.

We get 3 different behaviours.

Mine: I can change parameters from General Settings menu
@eugen-don: The above error is raised when accessing General Settings menu
Runbot instance of this PR: We cannot access General Settings menu at all

Any idea ?

I'll recheck the runbot instance when build is done

eugen-don · 2017-04-01T14:02:04Z

Hi @Fenkiou
I found the faulty module causing this error.

I made a PR #803

eugen-don

Tested on runbot.
Works on V. 10.0

Fenkiou · 2017-04-01T14:18:01Z

@eugen-don So you had this module installed too ? Otherwise I don't understand why this module is causing your error without being installed.

eugen-don · 2017-04-01T14:33:42Z

@Fenkiou Hi, yes it was installed on my local system and on the runbot instance of this pr, i uninstalled it on runbot and see there the general settings menu was accessible. On my local system the module version was a little bit older so it was causing a severe error. Notice base_exception was migrated recently.

eugen-don · 2017-04-01T15:04:53Z

@Fenkiou
Im actually confused myself, i just uninstalled the module and all works fine... i reinstall it and it causes errors... on runbot it didnt cause any errors only disabled the general settings menu... I see my base_exceptions was outdated. I did a fresh pull and now only the general settings menu is not clickable...

Fenkiou · 2017-04-01T15:28:44Z

@eugen-don I don't understand. Could you assure me that on a new odoo database with no other module installed than auth_admin_passkey, this is working correctly ?

Otherwise please describe all your steps to help me reproduce.

Fenkiou · 2017-05-05T20:05:31Z

Well, thanks to Travis, I learned how to use coverage on my machine.

res_users.py is 98% covered now, should increase global coverage.

Nothing to do with the PR
I'd like to know if it would possible to have Selenium installed on Travis ? As PhantomJS is installed, it could use it.

Writing UI test by writing steps in JS to call them from python test is completely absurd (IMO). I took inspiration in auth_signup_verify_email to write tests using python only but still, this is ugly and I couldn't write my tests as I wanted to.

EDIT: For the multiple database problem, a --db-filter should fix the issue.

Fenkiou · 2017-06-06T19:17:59Z

@pedrobaeza, @legalsylvain do you think a --db-filter could solve my problem with Travis ?

Garamotte · 2017-06-06T22:55:38Z

@Fenkiou Maybe you can start by calling the /web URL with the db argument, to define the database name in the session.
This is done here: https://github.com/OCA/server-tools/blob/9.0/oauth_provider/tests/common_test_controller.py#L66-L70

Fenkiou · 2017-06-07T05:36:38Z

Thanks @sylvain-garancher, this is an interesting one !

Is it intentional to not use HttpCase ?

Garamotte · 2017-06-07T07:25:35Z

I don't remember exactly, but I didn't achieve to do some tests with it, so I used werkzeug's test client instead of Odoo's HttpCase.

this fixes an issue reported on Transifex

…are unchecked

Remove authenticate as check_credentials is dedicated for this purpose. Removed mail translations maybe possible in some way ? Give some space to the code Make the addon compliant to OCA guidelines Adapt readme to new template and compress header in tests Make the addon a python package NOTE: authenticate() method cannot be used in tests because a new cr is created in _login method that does not contains our user. Signed-off-by: Eugen Don <[email protected]>

Fenkiou · 2017-06-25T15:01:39Z

It's working, finally !

You can merge when you'll have the time, thanks for the help.

hmrodrigues · 2017-07-29T17:24:08Z

How is this going? Will it be merged?

Syncing from upstream OCA/server-tools (11.0)

Fenkiou force-pushed the 10-mig-auth_admin_passkey branch from 6b6092e to 62d4a00 Compare March 15, 2017 18:21

Fenkiou force-pushed the 10-mig-auth_admin_passkey branch from 62d4a00 to 1cac349 Compare March 15, 2017 19:45

Fenkiou force-pushed the 10-mig-auth_admin_passkey branch 2 times, most recently from 470f921 to 659a354 Compare March 22, 2017 23:06

eugen-don reviewed Mar 25, 2017

View reviewed changes

eugen-don suggested changes Mar 25, 2017

View reviewed changes

Fenkiou force-pushed the 10-mig-auth_admin_passkey branch from 659a354 to 586f0d2 Compare March 28, 2017 17:43

pedrobaeza mentioned this pull request Mar 30, 2017

Migration to version 10.0 #565

Closed

63 tasks

Fenkiou force-pushed the 10-mig-auth_admin_passkey branch from 5d5b13d to ff10208 Compare April 1, 2017 11:14

eugen-don mentioned this pull request Apr 1, 2017

Fix menu in base_exception #803

Merged

eugen-don approved these changes Apr 1, 2017

View reviewed changes

Fenkiou force-pushed the 10-mig-auth_admin_passkey branch from ff10208 to 237bff3 Compare April 1, 2017 14:50

Fenkiou force-pushed the 10-mig-auth_admin_passkey branch from b2745d6 to 4431b82 Compare May 5, 2017 20:10

oca-transbot and others added 9 commits June 25, 2017 12:17

OCA Transbot updated translations from Transifex

dbcd090

auth_admin_passkey to new API (OCA#519)

64bdce9

OCA Transbot updated translations from Transifex

db4cd93

replace OpenERP with Odoo

fd187bc

this fixes an issue reported on Transifex

OCA Transbot updated translations from Transifex

118c459

auth_admin_passkey bug OCA#699

8c8fea0

crash when the options "Send email to ..." on the configuration page …

1fe54a4

…are unchecked

PEP8 fix

d899724

OCA Transbot updated translations from Transifex

20d4138

Fenkiou force-pushed the 10-mig-auth_admin_passkey branch 5 times, most recently from ba196d4 to 72254ae Compare June 25, 2017 11:55

Fenkiou force-pushed the 10-mig-auth_admin_passkey branch from 72254ae to e16b37a Compare June 25, 2017 12:24

yajo added the needs review label Jun 26, 2017

yajo added this to the 10.0 milestone Jun 26, 2017

legalsylvain merged commit 3b6b453 into OCA:10.0 Jul 31, 2017

Fenkiou deleted the 10-mig-auth_admin_passkey branch July 31, 2017 10:19

legalsylvain mentioned this pull request Aug 9, 2019

[12.0][MIG+REF] auth_admin_passkey OCA/server-auth#126

Merged

SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024

Merge pull request OCA#776 from OCA/11.0

ad47efc

Syncing from upstream OCA/server-tools (11.0)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[10.0][MIG] auth_admin_passkey #776

[10.0][MIG] auth_admin_passkey #776

Fenkiou commented Mar 13, 2017 •

edited

Loading

eugen-don commented Mar 15, 2017

Fenkiou commented Mar 15, 2017

eugen-don Mar 25, 2017 •

edited

Loading

Fenkiou Mar 28, 2017 •

edited

Loading

eugen-don left a comment •

edited

Loading

Fenkiou commented Mar 28, 2017

eugen-don commented Mar 29, 2017

JonathanNEMRY commented Mar 29, 2017

eugen-don commented Mar 29, 2017

Fenkiou commented Mar 29, 2017 •

edited

Loading

eugen-don commented Mar 29, 2017

eugen-don commented Mar 30, 2017 •

edited

Loading

Fenkiou commented Mar 30, 2017

eugen-don commented Mar 31, 2017 •

edited

Loading

eugen-don commented Mar 31, 2017

Fenkiou commented Apr 1, 2017 •

edited

Loading

eugen-don commented Apr 1, 2017

eugen-don left a comment

Fenkiou commented Apr 1, 2017

eugen-don commented Apr 1, 2017 •

edited

Loading

eugen-don commented Apr 1, 2017

Fenkiou commented Apr 1, 2017 •

edited

Loading

Fenkiou commented May 5, 2017 •

edited

Loading

Fenkiou commented Jun 6, 2017 •

edited

Loading

Garamotte commented Jun 6, 2017

Fenkiou commented Jun 7, 2017 •

edited

Loading

Garamotte commented Jun 7, 2017

Fenkiou commented Jun 25, 2017

hmrodrigues commented Jul 29, 2017

[10.0][MIG] auth_admin_passkey #776

[10.0][MIG] auth_admin_passkey #776

Conversation

Fenkiou commented Mar 13, 2017 • edited Loading

eugen-don commented Mar 15, 2017

Fenkiou commented Mar 15, 2017

eugen-don Mar 25, 2017 • edited Loading

Choose a reason for hiding this comment

Fenkiou Mar 28, 2017 • edited Loading

Choose a reason for hiding this comment

eugen-don left a comment • edited Loading

Choose a reason for hiding this comment

Fenkiou commented Mar 28, 2017

eugen-don commented Mar 29, 2017

JonathanNEMRY commented Mar 29, 2017

eugen-don commented Mar 29, 2017

Fenkiou commented Mar 29, 2017 • edited Loading

eugen-don commented Mar 29, 2017

eugen-don commented Mar 30, 2017 • edited Loading

Fenkiou commented Mar 30, 2017

eugen-don commented Mar 31, 2017 • edited Loading

eugen-don commented Mar 31, 2017

Fenkiou commented Apr 1, 2017 • edited Loading

eugen-don commented Apr 1, 2017

eugen-don left a comment

Choose a reason for hiding this comment

Fenkiou commented Apr 1, 2017

eugen-don commented Apr 1, 2017 • edited Loading

eugen-don commented Apr 1, 2017

Fenkiou commented Apr 1, 2017 • edited Loading

Fenkiou commented May 5, 2017 • edited Loading

Fenkiou commented Jun 6, 2017 • edited Loading

Garamotte commented Jun 6, 2017

Fenkiou commented Jun 7, 2017 • edited Loading

Garamotte commented Jun 7, 2017

Fenkiou commented Jun 25, 2017

hmrodrigues commented Jul 29, 2017

Fenkiou commented Mar 13, 2017 •

edited

Loading

eugen-don Mar 25, 2017 •

edited

Loading

Fenkiou Mar 28, 2017 •

edited

Loading

eugen-don left a comment •

edited

Loading

Fenkiou commented Mar 29, 2017 •

edited

Loading

eugen-don commented Mar 30, 2017 •

edited

Loading

eugen-don commented Mar 31, 2017 •

edited

Loading

Fenkiou commented Apr 1, 2017 •

edited

Loading

eugen-don commented Apr 1, 2017 •

edited

Loading

Fenkiou commented Apr 1, 2017 •

edited

Loading

Fenkiou commented May 5, 2017 •

edited

Loading

Fenkiou commented Jun 6, 2017 •

edited

Loading

Fenkiou commented Jun 7, 2017 •

edited

Loading