[9.0][MIG] auto_backup #526

lasley · 2016-08-23T01:47:32Z

This migrates auto_backup to v9

Note this was mostly unchanged except for two self.ensure_ones in db_backup.py

Added all the new fields and sentences. This will be the template for translations.

Full translation of the module to Dutch

Add Chinese translations to the module. Written by talway.

Changed some translations

Thanks to Martin Schmid!

could'nt > couldn't

Flemish translations are identical to Dutch.

Used to open fp = open(file_path,'wb') a few lines before it was needed. This shouldn't be too much of a problem but opening and closing it right after eachother keeps the session open for less time and there are less chances on failure.

[FIX] Flake8 [RM] useless files

[FIX] schedule_backup method [IMP] IT translation [IMP] tests

[FIX] flake8

[FIX] Contributors

…call of mail.mail

[FIX] Flake8

…y leak

elicoidal · 2016-08-23T03:40:12Z

auto_backup/data/backup_data.yml

@@ -0,0 +1,28 @@
+# -*- coding: utf-8 -*-


Arenot yml test files deprecated?

Are they? I would admittedly be very happy about that. Where'd you see this?

Not sure where: I will try to track down...

Maybe this? odoo/odoo#6287 (comment) YAML is not listed

there is no mention of it in v9 doc: https://www.odoo.com/documentation/9.0/reference/testing.html

Awesome well that just made me incredibly happy - I hate the YML tests. I'll move this to Python

@pedrobaeza do you have any pointer about the fact they are removed in v10? or deprecated in v9? May be we should discuss it at the OCA... I think it's a bit late to require no YAML test anymore in v9 given the OCA is already late on that v9 transition...

You can see in the comment above (odoo/odoo#6287 (comment)) the removal part. About deprecation, I don't remember where it was said, but it has been stated several times.

I see no point in discussing this: if the author of the PR agrees to change the test, perfect. If not, better YML test than nothing. In v10 we will need to change them. It's not a blocking point.

@pedrobaeza well if we still accept YML tests on 9.0 that's fine for me. The contrary would have annoyed me cause it would have slowed migration a bit too much... On the contrary, 9.0 to 10.0 migration should be pretty straightforward so it will be easier to bite the bullet.

In this case we're talking maybe a ten minute conversion too, so really not too much skin off my back even if I didn't already want to see YML die in a fire 😄

Just to note though, this isn't a test - it's the cron and message data.

lasley · 2016-08-23T03:50:45Z

FYI I'll be adding more tests as well

* compute_name * check_folder * action_sftp_test_connection * action_backup - sftp * action_backup_all * sftp_connection * filename

lasley · 2016-08-26T22:12:40Z

Alright comments handled and test coverage raised. Methods still missing coverage, but I figure they're probably fine given it was all pre-existing code:

backup_log
cleanup
cleanup_log

ivantodorovich

LGTM 👍

* Update english pot file Added all the new fields and sentences. This will be the template for translations. * Dutch translations Full translation of the module to Dutch * Chinese translations Add Chinese translations to the module. Written by talway. * Changes chinese translation Changed some translations * Full German translations Thanks to Martin Schmid! * Typo fix could'nt > couldn't * Flemish translations Flemish translations are identical to Dutch. * Open FTP session on the last moment possible Used to open fp = open(file_path,'wb') a few lines before it was needed. This shouldn't be too much of a problem but opening and closing it right after eachother keeps the session open for less time and there are less chances on failure. * Porting module to OCA 8.0 * [FIX] module * [FIX] bug logger --> _logger call [FIX] Flake8 [RM] useless files * [FIX] Readme.rst * [FIX] defaults value * [FIX] rebased commit * [RM] description index.html * [RF] porting to new api [FIX] schedule_backup method [IMP] IT translation [IMP] tests * [FIX] test * [FIX] flake8 * [IMP] deps in travis.yml [FIX] flake8 * [FIX] flake8 and pylint * [FIX] name of file * [FIX] autoremove method [FIX] Contributors * [FIX] mail.tempale seems not work in cron task, replaced with direct call of mail.mail * [FIX] Readme * [FIX] review remarks * [FIX] handled ssl hosts [FIX] Flake8 * [FIX] handled ssl hosts [FIX] Flake8 * [FIX] fixed, last review remarks * [FIX] travis lint check * [FIX] backup only local db , beacause xmlrpc call of dump cause memory leak * [RM] useless field * [FIX] check_dd method [ADD] test case improved * [auto_backup] Refactor. - Follow template README. - Remove HTML README. - Move models to models folder. - Model and view file names follow guidelines. - Unused methods cleanup. - Remove unneeded `.pot` file. - Fix permissons. - Follow PEP8 in names everywhere. - Set more descriptive field names. - Disable backups for other databases, for security. - Remove db name from generated file, for easier cleanup. - EAFP logic everywhere. - More descriptive name. - Data files moved to YAML, with cleaner ir.cron record creation. - Add permissions for db.backup model. - Icons. - Update tests with new format. - Storage method is a selectable, for easier extensibility. - Instead of custom mailing, it just has a mail thread where you can subscribe. - Should fix almost all comments in OCA#203. * Update english pot file Added all the new fields and sentences. This will be the template for translations. * Dutch translations Full translation of the module to Dutch * Chinese translations Add Chinese translations to the module. Written by talway. * Changes chinese translation Changed some translations * Full German translations Thanks to Martin Schmid! * Typo fix could'nt > couldn't * Flemish translations Flemish translations are identical to Dutch. * Open FTP session on the last moment possible Used to open fp = open(file_path,'wb') a few lines before it was needed. This shouldn't be too much of a problem but opening and closing it right after eachother keeps the session open for less time and there are less chances on failure. * Porting module to OCA 8.0 * [FIX] module * [FIX] bug logger --> _logger call [FIX] Flake8 [RM] useless files * [FIX] Readme.rst * [FIX] defaults value * [FIX] rebased commit * [RM] description index.html * [RF] porting to new api [FIX] schedule_backup method [IMP] IT translation [IMP] tests * [FIX] test * [FIX] flake8 * [IMP] deps in travis.yml [FIX] flake8 * [FIX] flake8 and pylint * [FIX] name of file * [FIX] autoremove method [FIX] Contributors * [FIX] mail.tempale seems not work in cron task, replaced with direct call of mail.mail * [FIX] Readme * [FIX] review remarks * [FIX] handled ssl hosts [FIX] Flake8 * [FIX] handled ssl hosts [FIX] Flake8 * [FIX] fixed, last review remarks * [FIX] travis lint check * [FIX] backup only local db , beacause xmlrpc call of dump cause memory leak * [RM] useless field * [FIX] check_dd method [ADD] test case improved * [auto_backup] Refactor. - Follow template README. - Remove HTML README. - Move models to models folder. - Model and view file names follow guidelines. - Unused methods cleanup. - Remove unneeded `.pot` file. - Fix permissons. - Follow PEP8 in names everywhere. - Set more descriptive field names. - Disable backups for other databases, for security. - Remove db name from generated file, for easier cleanup. - EAFP logic everywhere. - More descriptive name. - Data files moved to YAML, with cleaner ir.cron record creation. - Add permissions for db.backup model. - Icons. - Update tests with new format. - Storage method is a selectable, for easier extensibility. - Instead of custom mailing, it just has a mail thread where you can subscribe. - Should fix almost all comments in OCA#203. * Reduce headers. This respects the upstream license choice (GPL/AGPL) but reduces verbosity. It would be ideal to have everything under AGPL though. * Fix view format. * Add shortcut to execute backups from the "More" menu. * Avoid duplicated backups. * Make sure you don't backup inside the filestore folder. The filestore is saved in the backup, so if you save the backup in the filestore, you'd end up with a huge backup that includes itself and the universe may collapse. * [FIX] This was removing all databases. * FIX License type * OCA Transbot updated translations from Transifex * OCA Transbot updated translations from Transifex * OCA Transbot updated translations from Transifex * [FIX] auto_backup: bad reference to field sftp_private_key (OCA#423) Bump module version to 8.0.1.0.1 * [FIX] auto_backup: Empty dump using sftp backup option (OCA#432) * [FIX] logger db_backup for pysftp (OCA#419) * OCA Transbot updated translations from Transifex * OCA Transbot updated translations from Transifex * OCA Transbot updated translations from Transifex * OCA Transbot updated translations from Transifex * [FIX] remove en.po that was erroneously created by transbot * [MIG] auto_backup: Migrate to v9 * Add self.ensure_ones * Add test coverage * [ADD] auto_backup: Test coverage * compute_name * check_folder * action_sftp_test_connection * action_backup - sftp * action_backup_all * sftp_connection * filename

lmignon · 2016-11-24T10:20:42Z

@max3903 @lasley @pedrobaeza This merge must be reverted. The commit history is not preserved!
#619

This reverts commit 2798d45.

* Update english pot file Added all the new fields and sentences. This will be the template for translations. * Dutch translations Full translation of the module to Dutch * Chinese translations Add Chinese translations to the module. Written by talway. * Changes chinese translation Changed some translations * Full German translations Thanks to Martin Schmid! * Typo fix could'nt > couldn't * Flemish translations Flemish translations are identical to Dutch. * Open FTP session on the last moment possible Used to open fp = open(file_path,'wb') a few lines before it was needed. This shouldn't be too much of a problem but opening and closing it right after eachother keeps the session open for less time and there are less chances on failure. * Porting module to OCA 8.0 * [FIX] module * [FIX] bug logger --> _logger call [FIX] Flake8 [RM] useless files * [FIX] Readme.rst * [FIX] defaults value * [FIX] rebased commit * [RM] description index.html * [RF] porting to new api [FIX] schedule_backup method [IMP] IT translation [IMP] tests * [FIX] test * [FIX] flake8 * [IMP] deps in travis.yml [FIX] flake8 * [FIX] flake8 and pylint * [FIX] name of file * [FIX] autoremove method [FIX] Contributors * [FIX] mail.tempale seems not work in cron task, replaced with direct call of mail.mail * [FIX] Readme * [FIX] review remarks * [FIX] handled ssl hosts [FIX] Flake8 * [FIX] handled ssl hosts [FIX] Flake8 * [FIX] fixed, last review remarks * [FIX] travis lint check * [FIX] backup only local db , beacause xmlrpc call of dump cause memory leak * [RM] useless field * [FIX] check_dd method [ADD] test case improved * [auto_backup] Refactor. - Follow template README. - Remove HTML README. - Move models to models folder. - Model and view file names follow guidelines. - Unused methods cleanup. - Remove unneeded `.pot` file. - Fix permissons. - Follow PEP8 in names everywhere. - Set more descriptive field names. - Disable backups for other databases, for security. - Remove db name from generated file, for easier cleanup. - EAFP logic everywhere. - More descriptive name. - Data files moved to YAML, with cleaner ir.cron record creation. - Add permissions for db.backup model. - Icons. - Update tests with new format. - Storage method is a selectable, for easier extensibility. - Instead of custom mailing, it just has a mail thread where you can subscribe. - Should fix almost all comments in OCA#203. * Update english pot file Added all the new fields and sentences. This will be the template for translations. * Dutch translations Full translation of the module to Dutch * Chinese translations Add Chinese translations to the module. Written by talway. * Changes chinese translation Changed some translations * Full German translations Thanks to Martin Schmid! * Typo fix could'nt > couldn't * Flemish translations Flemish translations are identical to Dutch. * Open FTP session on the last moment possible Used to open fp = open(file_path,'wb') a few lines before it was needed. This shouldn't be too much of a problem but opening and closing it right after eachother keeps the session open for less time and there are less chances on failure. * Porting module to OCA 8.0 * [FIX] module * [FIX] bug logger --> _logger call [FIX] Flake8 [RM] useless files * [FIX] Readme.rst * [FIX] defaults value * [FIX] rebased commit * [RM] description index.html * [RF] porting to new api [FIX] schedule_backup method [IMP] IT translation [IMP] tests * [FIX] test * [FIX] flake8 * [IMP] deps in travis.yml [FIX] flake8 * [FIX] flake8 and pylint * [FIX] name of file * [FIX] autoremove method [FIX] Contributors * [FIX] mail.tempale seems not work in cron task, replaced with direct call of mail.mail * [FIX] Readme * [FIX] review remarks * [FIX] handled ssl hosts [FIX] Flake8 * [FIX] handled ssl hosts [FIX] Flake8 * [FIX] fixed, last review remarks * [FIX] travis lint check * [FIX] backup only local db , beacause xmlrpc call of dump cause memory leak * [RM] useless field * [FIX] check_dd method [ADD] test case improved * [auto_backup] Refactor. - Follow template README. - Remove HTML README. - Move models to models folder. - Model and view file names follow guidelines. - Unused methods cleanup. - Remove unneeded `.pot` file. - Fix permissons. - Follow PEP8 in names everywhere. - Set more descriptive field names. - Disable backups for other databases, for security. - Remove db name from generated file, for easier cleanup. - EAFP logic everywhere. - More descriptive name. - Data files moved to YAML, with cleaner ir.cron record creation. - Add permissions for db.backup model. - Icons. - Update tests with new format. - Storage method is a selectable, for easier extensibility. - Instead of custom mailing, it just has a mail thread where you can subscribe. - Should fix almost all comments in OCA#203. * Reduce headers. This respects the upstream license choice (GPL/AGPL) but reduces verbosity. It would be ideal to have everything under AGPL though. * Fix view format. * Add shortcut to execute backups from the "More" menu. * Avoid duplicated backups. * Make sure you don't backup inside the filestore folder. The filestore is saved in the backup, so if you save the backup in the filestore, you'd end up with a huge backup that includes itself and the universe may collapse. * [FIX] This was removing all databases. * FIX License type * OCA Transbot updated translations from Transifex * OCA Transbot updated translations from Transifex * OCA Transbot updated translations from Transifex * [FIX] auto_backup: bad reference to field sftp_private_key (OCA#423) Bump module version to 8.0.1.0.1 * [FIX] auto_backup: Empty dump using sftp backup option (OCA#432) * [FIX] logger db_backup for pysftp (OCA#419) * OCA Transbot updated translations from Transifex * OCA Transbot updated translations from Transifex * OCA Transbot updated translations from Transifex * OCA Transbot updated translations from Transifex * [FIX] remove en.po that was erroneously created by transbot * [MIG] auto_backup: Migrate to v9 * Add self.ensure_ones * Add test coverage * [ADD] auto_backup: Test coverage * compute_name * check_folder * action_sftp_test_connection * action_backup - sftp * action_backup_all * sftp_connection * filename

This reverts commit 2798d45.

max3903 · 2016-11-25T14:59:30Z

@lmignon Done

This reverts commit 0111be2.

Syncing from upstream OCA/server-tools (12.0)

Yenthe666 and others added 30 commits November 25, 2015 11:00

Update english pot file

4e31d62

Added all the new fields and sentences. This will be the template for translations.

Dutch translations

5ecc9d4

Full translation of the module to Dutch

Chinese translations

8317cb0

Add Chinese translations to the module. Written by talway.

Changes chinese translation

4dc62da

Changed some translations

Full German translations

1e44fb4

Thanks to Martin Schmid!

Typo fix

3577bdc

could'nt > couldn't

Flemish translations

6d4b34e

Flemish translations are identical to Dutch.

Open FTP session on the last moment possible

9255774

Used to open fp = open(file_path,'wb') a few lines before it was needed. This shouldn't be too much of a problem but opening and closing it right after eachother keeps the session open for less time and there are less chances on failure.

Porting module to OCA 8.0

5dfc524

[FIX] module

da98bcb

[FIX] bug logger --> _logger call

d345a71

[FIX] Flake8 [RM] useless files

[FIX] Readme.rst

680ca85

[FIX] defaults value

c6ac088

[FIX] rebased commit

93804fa

[RM] description index.html

2ac9136

[RF] porting to new api

1f76872

[FIX] schedule_backup method [IMP] IT translation [IMP] tests

[FIX] test

0d9dd41

[FIX] flake8

9839fb6

[IMP] deps in travis.yml

94df002

[FIX] flake8

[FIX] flake8 and pylint

b9e9fec

[FIX] name of file

d70ee0a

[FIX] autoremove method

788439d

[FIX] Contributors

[FIX] mail.tempale seems not work in cron task, replaced with direct …

749e236

…call of mail.mail

[FIX] Readme

09c2c77

[FIX] review remarks

bfa2b96

[FIX] handled ssl hosts

fd65859

[FIX] Flake8

[FIX] handled ssl hosts

0e27870

[FIX] Flake8

[FIX] fixed, last review remarks

8da47b1

[FIX] travis lint check

e67a490

[FIX] backup only local db , beacause xmlrpc call of dump cause memor…

ef75129

…y leak

elicoidal reviewed Aug 23, 2016
View reviewed changes

pedrobaeza mentioned this pull request Aug 23, 2016

Migration to version 9.0 #271

Closed

59 tasks

lasley force-pushed the release/9.0/auto_backup branch 5 times, most recently from 8c0b479 to 6cd224d Compare August 26, 2016 22:04

[ADD] auto_backup: Test coverage

f6b77ce

* compute_name * check_folder * action_sftp_test_connection * action_backup - sftp * action_backup_all * sftp_connection * filename

lasley force-pushed the release/9.0/auto_backup branch from 6cd224d to f6b77ce Compare August 26, 2016 22:07

lasley added needs review and removed work in progress labels Aug 26, 2016

max3903 approved these changes Nov 15, 2016

View reviewed changes

ivantodorovich approved these changes Nov 18, 2016

View reviewed changes

max3903 merged commit 2798d45 into OCA:9.0 Nov 18, 2016

lasley deleted the release/9.0/auto_backup branch November 18, 2016 20:27

lasley restored the release/9.0/auto_backup branch November 24, 2016 15:04

lasley deleted the release/9.0/auto_backup branch November 24, 2016 15:14

lasley added a commit to LasLabs/server-tools that referenced this pull request Nov 24, 2016

Revert "[9.0][MIG] auto_backup (OCA#526)"

8a078fc

This reverts commit 2798d45.

lasley added a commit to LasLabs/server-tools that referenced this pull request Nov 24, 2016

Revert "[9.0][MIG] auto_backup (OCA#526)"

483d9e5

This reverts commit 2798d45.

lasley mentioned this pull request Nov 24, 2016

[MIG][9.0] Redo auto_backup #620

Merged

max3903 pushed a commit that referenced this pull request Nov 25, 2016

Revert "[9.0][MIG] auto_backup (#526)"

0111be2

This reverts commit 2798d45.

lasley added a commit to LasLabs/server-tools that referenced this pull request Dec 7, 2016

Revert "Revert "[9.0][MIG] auto_backup (OCA#526)""

3d6338a

This reverts commit 0111be2.

SiesslPhillip pushed a commit to grueneerde/OCA-server-tools that referenced this pull request Nov 20, 2024

Merge pull request OCA#526 from OCA/12.0

a388de0

Syncing from upstream OCA/server-tools (12.0)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[9.0][MIG] auto_backup #526

[9.0][MIG] auto_backup #526

lasley commented Aug 23, 2016 •

edited

Loading

elicoidal Aug 23, 2016

lasley Aug 23, 2016

elicoidal Aug 23, 2016

sebalix Aug 23, 2016

elicoidal Aug 23, 2016

lasley Aug 23, 2016

rvalyi Aug 23, 2016

pedrobaeza Aug 23, 2016

rvalyi Aug 23, 2016

lasley Aug 23, 2016

lasley commented Aug 23, 2016

lasley commented Aug 26, 2016

ivantodorovich left a comment

lmignon commented Nov 24, 2016

max3903 commented Nov 25, 2016

[9.0][MIG] auto_backup #526

[9.0][MIG] auto_backup #526

Conversation

lasley commented Aug 23, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lasley commented Aug 23, 2016

lasley commented Aug 26, 2016

ivantodorovich left a comment

Choose a reason for hiding this comment

lmignon commented Nov 24, 2016

max3903 commented Nov 25, 2016

lasley commented Aug 23, 2016 •

edited

Loading