Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][MIG] sentry #1929

Closed
wants to merge 14 commits into from
Closed

Conversation

traviswaelbro
Copy link
Contributor

No description provided.

naglis and others added 14 commits November 16, 2020 22:40
* [ADD] sentry module

* [FIX] updated sentry module according to PR comments
- [FIX] sentry: fixes missing `raven` library preventing loading of modules
- [FIX] 2to3 script on py file
- [FIX] add requirements.txt
sentry: It is not always possible to read commit information from
a production environment. In those cases it is useful to be able
to set a release version manually.

[UPD] Update sentry.pot
[UPD] Update sentry.pot
@traviswaelbro traviswaelbro mentioned this pull request Nov 17, 2020
26 tasks
@traviswaelbro
Copy link
Contributor Author

The build appears to be failing due to some issue with pylint_odoo, which would be unrelated to this PR's changes as far as I can tell. It seems to be a known issue that can be fixed by using the latest version of isort.

pylint with optional checks..............................................Failed
- hook id: pylint
- duration: 1.24s
- exit code: 1
Traceback (most recent call last):
  File "/home/travis/.cache/pre-commit/repoo67eysv_/py_env-python3/bin/pylint", line 8, in <module>
    sys.exit(run_pylint())
  File "/home/travis/.cache/pre-commit/repoo67eysv_/py_env-python3/lib/python3.6/site-packages/pylint/__init__.py", line 22, in run_pylint
    PylintRun(sys.argv[1:])
  File "/home/travis/.cache/pre-commit/repoo67eysv_/py_env-python3/lib/python3.6/site-packages/pylint/lint/run.py", line 349, in __init__
    linter.check(args)
  File "/home/travis/.cache/pre-commit/repoo67eysv_/py_env-python3/lib/python3.6/site-packages/pylint/lint/pylinter.py", line 863, in check
    self.get_ast, self._iterate_file_descrs(files_or_modules)
  File "/home/travis/.cache/pre-commit/repoo67eysv_/py_env-python3/lib/python3.6/site-packages/pylint/lint/pylinter.py", line 896, in _check_files
    self._check_file(get_ast, check_astroid_module, name, filepath, modname)
  File "/home/travis/.cache/pre-commit/repoo67eysv_/py_env-python3/lib/python3.6/site-packages/pylint/lint/pylinter.py", line 922, in _check_file
    check_astroid_module(ast_node)
  File "/home/travis/.cache/pre-commit/repoo67eysv_/py_env-python3/lib/python3.6/site-packages/pylint/lint/pylinter.py", line 1055, in check_astroid_module
    ast_node, walker, rawcheckers, tokencheckers
  File "/home/travis/.cache/pre-commit/repoo67eysv_/py_env-python3/lib/python3.6/site-packages/pylint/lint/pylinter.py", line 1099, in _check_astroid_module
    walker.walk(ast_node)
  File "/home/travis/.cache/pre-commit/repoo67eysv_/py_env-python3/lib/python3.6/site-packages/pylint/utils/ast_walker.py", line 75, in walk
    self.walk(child)
  File "/home/travis/.cache/pre-commit/repoo67eysv_/py_env-python3/lib/python3.6/site-packages/pylint/utils/ast_walker.py", line 72, in walk
    callback(astroid)
  File "/home/travis/.cache/pre-commit/repoo67eysv_/py_env-python3/lib/python3.6/site-packages/pylint_odoo/checkers/modules_odoo.py", line 448, in visit_import
    self._check_imported_packages(node, name)
  File "/home/travis/.cache/pre-commit/repoo67eysv_/py_env-python3/lib/python3.6/site-packages/pylint_odoo/checkers/modules_odoo.py", line 406, in _check_imported_packages
    isort_obj = isort.SortImports(file_contents='')
AttributeError: module 'isort' has no attribute 'SortImports'

@moylop260 moylop260 mentioned this pull request Jan 22, 2021
@moylop260
Copy link
Contributor

@traviswaelbro
I will re-use this branch to make a new PR in order to set green.

I tried to use this PR but I don't have permission to push:

git push [email protected]:gobluestingray/server-tools.git 14.0-mig-sentry
ERROR: Permission to gobluestingray/server-tools.git denied to moylop260.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

So, I will continue here:

@moylop260 moylop260 closed this Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants