11.0 mig dbfilter from header #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
[MIG] migrate dbfilter_from_header to 10.0 I have also removed the ability to use HTTP_X_OPENERP_DBFILTER
updates were made in OCA#1137 by @TimLai125 and small lint fixes by @yelizariev
yelizariev
force-pushed
the
11.0-mig-dbfilter_from_header
branch
from
47eb3a4 to
dc50d04
Compare
|
LGTM |
ilmir-k
approved these changes
Apr 2, 2018
|
@pedrobaeza could you review it please? There are not many changes |
|
Sorry, I'm not a user of this module, so I can't say if it's correctly migrated. |
|
Can we merge this? |
|
Well, I see that you haven't reviewed properly (putting the approval), so I didn't see it your comment, but as there are 2 reviews counting yours and more than 5 days, I merge. |
|
@pedrobaeza Apologies, I see nothing in my UI that would indicate that I can do anything other than comment on this. |
|
Please see the image:
|
|
But now you can't approve as it's merged. Next time 😉 |
|
Oh apparently I can! Thanks! |
SiesslPhillip
pushed a commit
to grueneerde/OCA-server-tools
that referenced
this pull request
Nov 20, 2024
Syncing from upstream OCA/server-tools (16.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR with updates from #1137