[17.0][MIG] remove_odoo_enterprise: Migration to 17.0 #83
Conversation
remi-filament
force-pushed
the
17.0-mig-remove_odoo_enterprise
branch
from
a7722c7
to
16a073d
Compare
|
Some features are not working correctly:
The feature that work are:
|
remi-filament
force-pushed
the
17.0-mig-remove_odoo_enterprise
branch
from
16a073d
to
00aebc5
Compare
|
You are right @vincent-hatakeyama , thank you for checking that ! Web client does not use search() function anymore but web_search_read (since odoo/odoo#114024 and web_search_read was first added as unity_web_search_read with odoo/odoo#119034) Here, I asked myself whether we should override web_search_read or search_fetch as you propose, and I chose the second one so that it has broader impact than just on the web interface. Also, I merged the check done for payment provider and ir_module_module in the same base.py file since having it in 2 different places causes 2 overrides when searching in ir_module_module. |
|
Functional review LGTM, could you please squash administrative commits? |
|
Hi! Can you check my comment before ? so we can move forward with this migration :) Thanks! |
[FIX] Fixed payment module installation problem [FIX] Remove auto_install [FIX] Remove auto_install [FIX] precommit [FIX] precommit [ADD] Onestein as author
… the block are hidden
remi-filament
force-pushed
the
17.0-mig-remove_odoo_enterprise
branch
from
00aebc5
to
e86b875
Compare
|
Thanks for your review @carolinafernandez-tecnativa I have squashed bot commits. |
|
@pedrobaeza do you think that can we proceed to merge? |
|
@remi-filament just a little comment, please rename PR with OCA conventions. It should be named Check this https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0 for further information. |
pedrobaeza
changed the title
|
/ocabot migration remove_odoo_enterprise |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 8e433fc. Thanks a lot for contributing to OCA. ❤️ |
No description provided.