Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] sale_order_line_description: Migration to 11.0 #759

Merged
merged 13 commits into from
Jan 10, 2019
Merged

[MIG] sale_order_line_description: Migration to 11.0 #759

merged 13 commits into from
Jan 10, 2019

Conversation

cubells
Copy link
Member

@cubells cubells commented Dec 10, 2018

Standard migration
Add oca fragments for readme information

cc @Tecnativa

@cubells cubells force-pushed the 11.0-mig-sale_order_line_description branch 2 times, most recently from 1b84e10 to 185521a Compare December 10, 2018 09:02
@pedrobaeza pedrobaeza added this to the 11.0 milestone Dec 13, 2018
pedrobaeza
pedrobaeza requested changes Dec 13, 2018
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has the same UI problem than purchase one.

Please also squash commit history by author.

@pedrobaeza pedrobaeza mentioned this pull request Dec 13, 2018
Closed
65 tasks
@cubells cubells force-pushed the 11.0-mig-sale_order_line_description branch from 185521a to 3c92617 Compare December 13, 2018 14:52
@cubells
Copy link
Member Author

cubells commented Dec 14, 2018

@pedrobaeza done!

pedrobaeza
pedrobaeza requested changes Dec 14, 2018
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cubells I have marked the check, but the code stills appears in the quotation:
seleccion_023

@cubells cubells force-pushed the 11.0-mig-sale_order_line_description branch 2 times, most recently from bace41f to 356fcfe Compare December 14, 2018 18:05
@cubells
Copy link
Member Author

cubells commented Dec 14, 2018

@pedrobaeza you must activate two checks: one in Sales > Settings > Sales & Orders > Product Sale
description and once you've checked this general option, you must check the option "Use only product purchase description on order lines" for every user you want.

I've updated readme to make it clearer.

tafaRU
tafaRU requested changes Dec 14, 2018
View reviewed changes
Copy link
Member

@tafaRU tafaRU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one request, the rest LGTM.
Thanks!

sale_order_line_description/README.rst
#. Add or modify a sale description to any of your products.
#. Create a sale order and add a sale order line with this product and check
out that now sale order line description only contains the description you
are created.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are created: could you please rephrase it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tafaRU can you recheck now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, now the USAGE section LGTM. Thanks!

lfreeke
lfreeke approved these changes Dec 16, 2018
View reviewed changes
Copy link

@lfreeke lfreeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (functional test)

nikul-serpentcs
nikul-serpentcs approved these changes Dec 17, 2018
View reviewed changes
Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cubells The rest LGTM 👍 : Only minor change, Some commits are Transifex, Can you please Fix it.
mig sale_order_line_description migration to 11 0 by cubells pull request 759 oca sale workflow

@cubells cubells force-pushed the 11.0-mig-sale_order_line_description branch from 356fcfe to b047a37 Compare December 17, 2018 07:44
@cubells
Copy link
Member Author

cubells commented Dec 17, 2018

@nikul-serpentcs done!

@pedrobaeza pedrobaeza force-pushed the 11.0-mig-sale_order_line_description branch from b047a37 to 1759303 Compare January 10, 2019 17:34
@pedrobaeza pedrobaeza merged commit 781c7c6 into OCA:11.0 Jan 10, 2019
@pedrobaeza pedrobaeza deleted the 11.0-mig-sale_order_line_description branch January 10, 2019 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikul-serpentcs nikul-serpentcs nikul-serpentcs approved these changes

@lfreeke lfreeke lfreeke approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@tafaRU tafaRU tafaRU approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.